Review 11.5 Merged

75849[BUGFIX] Fix glitches in controls of EXT:viewpage

Andreas Kienast CR +2 V +2 Easy +7 −5 updated 09/23/22, 17:32

Commit message

The controls of EXT:viewpage have several glitches which are fixed in
this patch:

* Setting a custom width now properly updates the selector in the preset
  dropdown
* Updating the custom size also stores the data in the "current" scope
* The controls now adapt to the dark appearance of the backend module

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Andreas Kienast uploaded patch set 1 09/22/22, 12:04

  2. core-ci voted on patch set 1 V -1 09/22/22, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31433

  3. Andreas Kienast uploaded patch set 2 09/22/22, 12:22

  4. core-ci voted on patch set 2 V +1 09/22/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31438

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 09/23/22, 17:32

  6. Andreas Kienast merged patch set 3 09/23/22, 17:32