Review main Merged

75850[BUGFIX] Do not override width of preview mode selector

Andreas Kienast CR +2 V +2 Easy +3 −21 updated 09/29/22, 11:37

Commit message

The preview mode selector doesn't change its width anymore based on the
largest element available as the behavior may become glitchy and hard to
replicate once jQuery is gone.

As a drive-by fix, the iframes have a white background in case the pages
have no dedicated CSS to avoid overlapping the content of the iframes in
the "Slider" preview mode.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Andreas Kienast uploaded patch set 1 09/22/22, 12:43

  2. Andreas Kienast commented on patch set 1 CR -1 09/22/22, 12:45

    the whole selector thing looks fishy
  3. core-ci voted on patch set 1 V +1 09/22/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31440

  4. Andreas Kienast uploaded patch set 2 09/22/22, 12:55

  5. core-ci voted on patch set 2 V +1 09/22/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31443

  6. Andreas Kienast uploaded patch set 3 09/22/22, 13:05

  7. core-ci voted on patch set 3 V +1 09/22/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31444

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 09/22/22, 13:51

  9. Andreas Kienast updated the commit message in patch set 4 09/22/22, 14:02

  10. core-ci voted on patch set 4 V +1 09/22/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31453

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 09/22/22, 15:05

  12. Frank Nägler voted on patch set 4 V +1 CR +1 09/29/22, 11:16

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 09/29/22, 11:37

  14. Andreas Kienast merged patch set 5 09/29/22, 11:37