Review main Merged

75853[TASK] Streamline FormEngine inline-relation JavaScript module loading

Benjamin Franzke CR +2 V +2 Normal +11 −135 updated 09/23/22, 10:48

Commit message

Support for non JavaScriptModuleInstruction RequireJS invocations
in FormEngine has been dropped in #96221, but the special ajax
inline-relation was kept by accident. This is now streamlined to
throw the same exception that FormResultCompiler throws for non
JavaScriptModuleInstructions.

Also the internal FormResultTrait is removed as
serializeJavaScriptModuleInstructionItems() is no longer used.
(Note that is was already unused, as the only remaing user
createExecutableStringRepresentationOfRegisteredRequireJsModules()
was only called with skipInstructions=true which skipped the
serialization in favor of direct JavaScriptItem passing).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 810

  1. Benjamin Franzke uploaded patch set 1 09/22/22, 13:19

  2. core-ci voted on patch set 1 V -1 09/22/22, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31447

  3. Benjamin Franzke uploaded patch set 2 09/22/22, 14:09

  4. core-ci voted on patch set 2 V +1 09/22/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31454

  5. Benni Mack voted on patch set 2 CR +1 09/22/22, 22:35

  6. Andreas Kienast voted on patch set 2 CR +1 09/23/22, 06:15

  7. Benni Mack voted on patch set 2 V +1 09/23/22, 09:53

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 09/23/22, 10:16

  9. Georg Ringer voted on patch set 2 V +2 CR +2 09/23/22, 10:48

  10. Georg Ringer merged patch set 3 09/23/22, 10:48