75855[FEATURE] Support javaScriptModules in FormEngine resultArray
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +1
- core-ci +1 CI
Issues 3
Files 48
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php2+5 −2
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+3 −1
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+3 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+3 −1
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+3 −1
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+5 −5
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+5 −5
- typo3/sysext/backend/Classes/Form/Container/SiteLanguageContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/TabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/CategoryElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/ColorElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/FolderElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+1 −1
Show 28 more files
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/NumberElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Event/CustomFileControlsEvent.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/InsertClipboard.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/ResetSelection.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/LocalizationStateSelector.php+1 −1
- typo3/sysext/backend/Classes/Form/AbstractNode.php+12 −4
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+28 −2
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+7 −7
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+5 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-98431-ReplaceRequireJsModulesInFormEngineResultArray.rstnew+69 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98431-SupportJavaScriptModulesInFormEngineResultArray.rstnew+44 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+1 −1
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+1 −1
Review log 1827
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/22/22, 15:37
-
core-ci voted on patch set 1 V -1 09/22/22, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31457
-
Benjamin Franzke uploaded patch set 2 09/22/22, 15:55
-
core-ci voted on patch set 2 V +1 09/22/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31458
-
Benjamin Franzke uploaded patch set 3 10/01/22, 19:49
-
core-ci voted on patch set 3 V +1 10/01/22, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31843
-
Benjamin Franzke uploaded patch set 4 10/01/22, 20:17
-
core-ci voted on patch set 4 V +1 10/01/22, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31847
-
Benni Mack voted on patch set 4 V +1 CR +1 10/01/22, 21:31
-
Chris Müller uploaded patch set 5 10/02/22, 06:11
-
core-ci voted on patch set 5 V +1 10/02/22, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31858
-
Benni Mack commented on patch set 5 10/02/22, 10:10
let's wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/75916 is merged and then adapt the new type=file as well -
Benjamin Franzke uploaded patch set 6 10/02/22, 14:05
-
core-ci voted on patch set 6 V -1 10/02/22, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31881
-
Benjamin Franzke uploaded patch set 7 10/02/22, 16:10
-
Benjamin Franzke commented on patch set 7 10/02/22, 16:10
Reply
Done -
core-ci voted on patch set 7 V +1 10/02/22, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31891
-
Oliver Hader commented on patch set 7 10/02/22, 16:34
AbstractFormEngineAjaxController.php:37What about the `$deprecated` param? -
Oliver Hader voted on patch set 7 V +1 10/02/22, 16:36
-
Benjamin Franzke uploaded patch set 8 10/02/22, 16:54
-
Benjamin Franzke commented on patch set 8 10/02/22, 16:54
AbstractFormEngineAjaxController.php:37Replyoh, thx, I wanted to trigger a deprecation error in there when $modules comes from the deprecated array-key (so when $deprecated = true). Fixed to do so. -
core-ci voted on patch set 8 V -1 10/02/22, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31896
-
Benjamin Franzke uploaded patch set 9 10/02/22, 17:08
-
Oliver Hader voted on patch set 9 V +1 CR +1 10/02/22, 17:09
-
core-ci voted on patch set 9 V +1 10/02/22, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31898
-
Georg Ringer voted on patch set 9 V +2 CR +2 10/02/22, 17:47
-
Georg Ringer merged patch set 10 10/02/22, 17:47