Review main Merged

75855[FEATURE] Support javaScriptModules in FormEngine resultArray

Benjamin Franzke CR +2 V +2 Hard +239 −82 updated 10/02/22, 17:47

Commit message

The array key `javaScriptModules` accepts a list of
JavaScriptModuleInstructions the same way as `requireJsModules`
did. In contrast to `requireJsModules` it has a generic name in
order to reflect that the array is module-loader independent.
(both, newer ES6 modules and legacy RequireJS modules are
supported via JavaScriptModuleInstruction).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 3

Files 48

Show 28 more files

Review log 1827

Show 12 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/22/22, 15:37

  2. core-ci voted on patch set 1 V -1 09/22/22, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31457

  1. Benjamin Franzke uploaded patch set 2 09/22/22, 15:55

  2. core-ci voted on patch set 2 V +1 09/22/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31458

  3. Benjamin Franzke uploaded patch set 3 10/01/22, 19:49

  4. core-ci voted on patch set 3 V +1 10/01/22, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31843

  5. Benjamin Franzke uploaded patch set 4 10/01/22, 20:17

  6. core-ci voted on patch set 4 V +1 10/01/22, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31847

  7. Benni Mack voted on patch set 4 V +1 CR +1 10/01/22, 21:31

  8. Chris Müller uploaded patch set 5 10/02/22, 06:11

  9. core-ci voted on patch set 5 V +1 10/02/22, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31858

  10. Benni Mack commented on patch set 5 10/02/22, 10:10

    let's wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/75916 is merged and then adapt the new type=file as well
  11. Benjamin Franzke uploaded patch set 6 10/02/22, 14:05

  12. core-ci voted on patch set 6 V -1 10/02/22, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31881

  13. Benjamin Franzke uploaded patch set 7 10/02/22, 16:10

  14. Benjamin Franzke commented on patch set 7 10/02/22, 16:10

    Reply

    Done
  15. core-ci voted on patch set 7 V +1 10/02/22, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31891

  16. Oliver Hader commented on patch set 7 10/02/22, 16:34

    AbstractFormEngineAjaxController.php:37

    What about the `$deprecated` param?
  17. Oliver Hader voted on patch set 7 V +1 10/02/22, 16:36

  18. Benjamin Franzke uploaded patch set 8 10/02/22, 16:54

  19. Benjamin Franzke commented on patch set 8 10/02/22, 16:54

    AbstractFormEngineAjaxController.php:37 Reply

    oh, thx, I wanted to trigger a deprecation error in there when $modules comes from the deprecated array-key (so when $deprecated = true). Fixed to do so.
  20. core-ci voted on patch set 8 V -1 10/02/22, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31896

  21. Benjamin Franzke uploaded patch set 9 10/02/22, 17:08

  22. Oliver Hader voted on patch set 9 V +1 CR +1 10/02/22, 17:09

  23. core-ci voted on patch set 9 V +1 10/02/22, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31898

  24. Georg Ringer voted on patch set 9 V +2 CR +2 10/02/22, 17:47

  25. Georg Ringer merged patch set 10 10/02/22, 17:47