Review main Merged

75856[TASK] Remove invalid deprecation trigger in dashboard

Benjamin Franzke CR +2 V +2 Easy +0 −1 updated 09/23/22, 09:52

Commit message

The method DashboardInitializationService::getRequireJsModules()
triggers a deprecation error, but is is actually in use and
thus should not create an error.
The deprecation message for registered requirejs modules is logged
earlier, so this message is not been useful, and didn't actually
reflect whether the deprecated interface was used or not.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/22/22, 16:02

  2. core-ci voted on patch set 1 V +1 09/22/22, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31460

  3. Benni Mack voted on patch set 1 CR +1 09/22/22, 22:37

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 09/23/22, 06:12

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 09/23/22, 09:52

  6. Oli Bartsch merged patch set 2 09/23/22, 09:52