Review main Merged Breaking

75861[!!!][TASK] Remove workspace tsconfig swapMode and changeStageMode

Christian Kuhn CR +2 V +2 Hard +63 −483 updated 09/26/22, 14:44

Commit message

EXT:workspace User TSconfig options "options.workspaces.swapMode"
and "options.workspaces.changeStageMode":

* They are at least partially broken since the switch to
  doctrine/dbal in core v8. This hasn't been reported as
  bug, we can safely assume they are used very seldom.
* They are rather hard to understand and usability wise
  questionable since more elements than selected in the Backend
  module magically change workspace state or are published.
* The options are at least partially obsolete since the
  core considers references for important child records
  internally already - for instance for inline parent-child
  relations - and changes child state as needed.

The patch removes these TSconfig options and their
implementation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1116

  1. Christian Kuhn uploaded patch set 1 09/23/22, 11:47

  2. core-ci voted on patch set 1 V -1 09/23/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31477

  3. Christian Kuhn uploaded patch set 2 09/23/22, 13:01

  4. core-ci voted on patch set 2 V +1 09/23/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31478

  5. Simon Schaufelberger commented on patch set 2 09/24/22, 23:18

    can this make it into v12?
  6. Christian Kuhn commented on patch set 2 09/26/22, 10:04

    Reply

    yes. will finish now.
  7. Christian Kuhn uploaded patch set 3 09/26/22, 10:39

  8. core-ci voted on patch set 3 V +1 09/26/22, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31535

  9. Andreas Kienast updated the commit message in patch set 4 09/26/22, 11:00

  10. Andreas Kienast commented on patch set 5 09/26/22, 11:01

    Published edit on patch set 4.
  11. core-ci voted on patch set 5 V +1 09/26/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31538

  12. core-ci voted on patch set 4 V +1 09/26/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31537

  13. Stefan Bürk voted on patch set 5 V +1 CR +1 09/26/22, 11:42

  14. Benni Mack voted on patch set 5 V +1 CR +1 09/26/22, 12:12

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 09/26/22, 14:44

  16. Christian Kuhn merged patch set 6 09/26/22, 14:44