Review main Merged

75862[TASK] Remove jQuery and jQuery UI from EXT:viewpage

Andreas Kienast CR +2 V +2 Hard +170 −158 updated 09/28/22, 09:44

Commit message

jQuery and jQuery UI is now removed from EXT:viewpage. jQuery UI was
used to make the preview frame resizable, which is now handled by
interact.js, which may be used for further replacements.

Executed command:

    npm install --save interactjs

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1215

  1. Andreas Kienast uploaded patch set 1 09/23/22, 14:28

  2. Andreas Kienast commented on patch set 1 CR -2 09/23/22, 14:29

  3. core-ci voted on patch set 1 V -1 09/23/22, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31480

  4. Andreas Kienast uploaded patch set 2 09/23/22, 17:35

  5. Andreas Kienast voted on patch set 2 CR 0 09/23/22, 17:35

  6. Andreas Kienast uploaded patch set 3 09/23/22, 17:38

  7. core-ci voted on patch set 3 V +1 09/23/22, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31492

  8. Georg Ringer voted on patch set 3 V +1 CR +1 09/27/22, 07:23

  9. Benni Mack voted on patch set 3 CR +1 09/27/22, 09:34

  10. Andreas Kienast uploaded patch set 4 09/27/22, 12:17

  11. core-ci voted on patch set 4 V +1 09/27/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31586

  12. Georg Ringer voted on patch set 4 V +1 CR +1 09/27/22, 12:55

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 09/28/22, 09:43

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 09/28/22, 09:44

  15. Andreas Kienast merged patch set 5 09/28/22, 09:44