Review main Merged Breaking

75864[!!!][FEATURE] Use Routing for getQueryArguments / addQueryString

Benni Mack CR +2 V +2 Hard +257 −66 updated 10/03/22, 10:33

Commit message

With Typolink (and the typolink ViewHelpers), a new option is
now available to allow to add ALL current queryParameters
to the created URL when creating frontend links.

10 = TEXT
10.typolink.parameter = 12
10.typolink.addQueryString = untrusted

addQueryString now allows to be set to "0" (do not do anything),
or "1"/"true" or "untrusted" (new) which then makes it possible
to add only "safe" query parameters which have been matched
during the routing process.

The breaking change here is that "addQueryString = 1" does
- by default - only include the mapped query arguments from
the Page Routing, avoiding unneeded GET parameters to be
added by default.

The affected method has been moved from ContentObjectRenderer
to PageLinkBuilder now.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1

Issues 1

Files 13

Review log 1724

  1. Benni Mack uploaded patch set 1 09/23/22, 15:28

  2. core-ci voted on patch set 1 V -1 09/23/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31485

  3. Benni Mack uploaded patch set 2 09/30/22, 20:05

  4. core-ci voted on patch set 2 V -1 09/30/22, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31767

  5. Benni Mack uploaded patch set 3 09/30/22, 21:34

  6. Oliver Hader commented on patch set 3 CR +1 09/30/22, 22:30

    Looks good (even it's WIP)
  7. Benni Mack uploaded patch set 4 09/30/22, 22:31

  8. core-ci voted on patch set 3 V -1 09/30/22, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31778

  9. Benni Mack uploaded patch set 5 09/30/22, 23:00

  10. core-ci voted on patch set 5 V -1 09/30/22, 23:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31783

  11. Benni Mack uploaded patch set 6 09/30/22, 23:16

  12. core-ci voted on patch set 6 V +1 09/30/22, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31785

  13. core-ci voted on patch set 4 V -1 09/30/22, 23:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31781

  14. Oliver Hader voted on patch set 6 CR +1 10/01/22, 07:47

  15. Oliver Hader voted on patch set 6 V +1 10/01/22, 08:22

  16. Georg Ringer commented on patch set 6 CR -1 10/01/22, 18:34

    pls ask in slack
  17. Oliver Hader commented on patch set 6 10/02/22, 16:50

    @Georg: Can you please explain the -1 a bit... alternatively, posting a short summary to our (internal) core-merger channel would be fine as well. Thanks in advance!
  18. Georg Ringer commented on patch set 6 10/02/22, 19:39

    Reply Unresolved

    done
  19. Oliver Hader uploaded patch set 7 10/02/22, 20:53

  20. Oliver Hader commented on patch set 7 V +1 CR +1 10/02/22, 20:57

    Unresolved

    Resolved conflict. This change addresses an issue in the TYPO3 core, that was described in https://typo3.org/security/advisory/typo3-psa-2021-003 already, thus it enhances security. However, route settings become mandatory for e.g. canonical URLs (ext:seo) at the same time. Any change in this area will modify existing behavior and is considered breaking. That is why this should go to TYPO3 v12.0 and can be streamlined further after that.
  21. Georg Ringer voted on patch set 7 V +2 CR +2 10/02/22, 20:57

  22. Georg Ringer merged patch set 8 10/02/22, 20:57

  23. core-ci voted on patch set 7 V +1 10/02/22, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31915

  24. Oliver Hader commented on patch set 8 10/03/22, 10:33