75864[!!!][FEATURE] Use Routing for getQueryArguments / addQueryString
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +1
Issues 1
Files 13
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98488-TypolinkOptionAddQueryStringOnlyIncludesResolvedQueryArguments.rstnew+49 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-98488-ContentObjectRenderer-getQueryArguments.rstnew+36 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98488-AdditionalSettingForTypolinkOptionAddQueryString.rstnew+26 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+8 −8
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+40 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −44
- typo3/sysext/frontend/Tests/Unit/Typolink/PageLinkBuilderTest.phpnew+76 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1724
-
Benni Mack uploaded patch set 1 09/23/22, 15:28
-
core-ci voted on patch set 1 V -1 09/23/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31485
-
Benni Mack uploaded patch set 2 09/30/22, 20:05
-
core-ci voted on patch set 2 V -1 09/30/22, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31767
-
Benni Mack uploaded patch set 3 09/30/22, 21:34
-
Oliver Hader commented on patch set 3 CR +1 09/30/22, 22:30
Looks good (even it's WIP) -
Benni Mack uploaded patch set 4 09/30/22, 22:31
-
core-ci voted on patch set 3 V -1 09/30/22, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31778
-
Benni Mack uploaded patch set 5 09/30/22, 23:00
-
core-ci voted on patch set 5 V -1 09/30/22, 23:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31783
-
Benni Mack uploaded patch set 6 09/30/22, 23:16
-
core-ci voted on patch set 6 V +1 09/30/22, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31785
-
core-ci voted on patch set 4 V -1 09/30/22, 23:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31781
-
Oliver Hader voted on patch set 6 CR +1 10/01/22, 07:47
-
Oliver Hader voted on patch set 6 V +1 10/01/22, 08:22
-
Georg Ringer commented on patch set 6 CR -1 10/01/22, 18:34
pls ask in slack -
Oliver Hader commented on patch set 6 10/02/22, 16:50
@Georg: Can you please explain the -1 a bit... alternatively, posting a short summary to our (internal) core-merger channel would be fine as well. Thanks in advance! -
Georg Ringer commented on patch set 6 10/02/22, 19:39
Reply Unresolved
done -
Oliver Hader uploaded patch set 7 10/02/22, 20:53
-
Oliver Hader commented on patch set 7 V +1 CR +1 10/02/22, 20:57
Unresolved
Resolved conflict. This change addresses an issue in the TYPO3 core, that was described in https://typo3.org/security/advisory/typo3-psa-2021-003 already, thus it enhances security. However, route settings become mandatory for e.g. canonical URLs (ext:seo) at the same time. Any change in this area will modify existing behavior and is considered breaking. That is why this should go to TYPO3 v12.0 and can be streamlined further after that. -
Georg Ringer voted on patch set 7 V +2 CR +2 10/02/22, 20:57
-
Georg Ringer merged patch set 8 10/02/22, 20:57
-
core-ci voted on patch set 7 V +1 10/02/22, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31915
-
Oliver Hader commented on patch set 8 10/03/22, 10:33
→ docs follow-up https://review.typo3.org/c/Packages/TYPO3.CMS/+/75947