Review main Merged

75865[FEATURE] Auto creation of database fields for TCA "slug"

Georg Ringer CR +2 V +2 Normal +65 −1 updated 09/30/22, 11:10

Commit message

Create database fields for TCA type `slug` columns automatically
if they have not already been defined.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Torben Hansen +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Torben Hansen +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1214

  1. Georg Ringer uploaded patch set 1 09/23/22, 16:24

  2. Georg Ringer commented on patch set 1 09/23/22, 16:25

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/23/22, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31489

  4. Benni Mack voted on patch set 1 CR +1 09/23/22, 16:32

  5. Benni Mack voted on patch set 1 V +1 09/28/22, 13:34

  6. Nikita Hovratov voted on patch set 1 V +1 CR +1 09/28/22, 16:22

  7. Christian Kuhn commented on patch set 1 CR -1 09/29/22, 12:54

    We should add some test in DefaultTcaSchemaTest - similar to the other ones.
  8. Georg Ringer uploaded patch set 2 09/30/22, 05:44

  9. core-ci voted on patch set 2 V +1 09/30/22, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31736

  10. Nikita Hovratov voted on patch set 2 V +1 CR +1 09/30/22, 07:11

  11. Benni Mack voted on patch set 2 V +1 CR +1 09/30/22, 08:11

  12. Torben Hansen voted on patch set 2 V +1 CR +1 09/30/22, 10:38

  13. Georg Ringer voted on patch set 2 V +2 CR +2 09/30/22, 11:10

  14. Georg Ringer merged patch set 3 09/30/22, 11:10