75869[TASK] Use LinkResult object for HMENU menu items
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php2+8 −13
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+6 −6
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+2 −1
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+3 −2
Review log 1624
-
Benni Mack uploaded patch set 1 09/26/22, 12:15
-
core-ci voted on patch set 1 V -1 09/26/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31539
-
Benni Mack uploaded patch set 2 09/28/22, 13:42
-
core-ci voted on patch set 2 V -1 09/28/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31657
-
Benni Mack uploaded patch set 3 09/28/22, 14:00
-
Benni Mack uploaded patch set 4 09/28/22, 14:03
-
core-ci voted on patch set 3 V +1 09/28/22, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31663
-
core-ci voted on patch set 4 V -1 09/28/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31664
-
Benni Mack updated the commit message in patch set 5 09/28/22, 14:32
-
core-ci voted on patch set 5 V +1 09/28/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31666
-
Nikita Hovratov uploaded patch set 6 09/28/22, 16:31
-
core-ci voted on patch set 6 V +1 09/28/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31669
-
Nikita Hovratov commented on patch set 6 09/28/22, 17:22
-
Nikita Hovratov uploaded patch set 7 09/28/22, 17:22
-
core-ci voted on patch set 7 V +1 09/28/22, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31671
-
Benni Mack commented on patch set 7 09/28/22, 19:42
Thanks for looking into it. Can you share your TypoScript in the ticket? I will then create a test for this -
Nikita Hovratov commented on patch set 7 09/29/22, 11:40
Reply
I added it to the issue. I used only the latter one, as the styleguide menu already generated a menu with the link. But this should work. -
Benni Mack uploaded patch set 8 10/28/22, 21:09
-
Benni Mack commented on patch set 8 10/28/22, 21:09
AbstractMenuContentObject.php:1231ReplyI've reworked the change and moved it back to the TextMenuContentObject by modifying the linkresult object. -
core-ci voted on patch set 8 V +1 10/28/22, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32878
-
Nikita Hovratov voted on patch set 8 V +1 CR +1 10/29/22, 08:51
-
Stefan Bürk voted on patch set 8 CR +1 10/29/22, 11:24
-
Stefan Bürk voted on patch set 8 V +2 CR +2 10/29/22, 12:28
-
Stefan Bürk merged patch set 9 10/29/22, 12:28
AbstractMenuContentObject.php:1231