Review main Merged

75869[TASK] Use LinkResult object for HMENU menu items

Benni Mack CR +2 V +2 Easy +19 −22 updated 10/29/22, 12:28

Commit message

This change allows to use the LinkResult object
for custom HMENU generation moving HMENU to be
more consistent like typolink() has been
aligned in TYPO3 v12 as well.

The related code pieces are rather internal
and hardly relevant to userland code outside
of TYPO3 Core.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1624

  1. Benni Mack uploaded patch set 1 09/26/22, 12:15

  2. core-ci voted on patch set 1 V -1 09/26/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31539

  3. Benni Mack uploaded patch set 2 09/28/22, 13:42

  4. core-ci voted on patch set 2 V -1 09/28/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31657

  5. Benni Mack uploaded patch set 3 09/28/22, 14:00

  6. Benni Mack uploaded patch set 4 09/28/22, 14:03

  7. core-ci voted on patch set 3 V +1 09/28/22, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31663

  8. core-ci voted on patch set 4 V -1 09/28/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31664

  9. Benni Mack updated the commit message in patch set 5 09/28/22, 14:32

  10. core-ci voted on patch set 5 V +1 09/28/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31666

  11. Nikita Hovratov uploaded patch set 6 09/28/22, 16:31

  12. core-ci voted on patch set 6 V +1 09/28/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31669

  13. Nikita Hovratov commented on patch set 6 09/28/22, 17:22

    AbstractMenuContentObject.php:1231

    This does not work. The link title won't get overridden like before. I debugged a bit and found out, that the cache is the culprit. As the alternative title is not used in the cache hash, another rendered menu link with the same target will be returned early. Right now it is solved by changing it after the link generation inside TextMenuContentObject.
  14. Nikita Hovratov uploaded patch set 7 09/28/22, 17:22

  15. core-ci voted on patch set 7 V +1 09/28/22, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31671

  16. Benni Mack commented on patch set 7 09/28/22, 19:42

    Thanks for looking into it. Can you share your TypoScript in the ticket? I will then create a test for this
  17. Nikita Hovratov commented on patch set 7 09/29/22, 11:40

    Reply

    I added it to the issue. I used only the latter one, as the styleguide menu already generated a menu with the link. But this should work.
  18. Benni Mack uploaded patch set 8 10/28/22, 21:09

  19. Benni Mack commented on patch set 8 10/28/22, 21:09

    AbstractMenuContentObject.php:1231 Reply

    I've reworked the change and moved it back to the TextMenuContentObject by modifying the linkresult object.
  20. core-ci voted on patch set 8 V +1 10/28/22, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32878

  21. Nikita Hovratov voted on patch set 8 V +1 CR +1 10/29/22, 08:51

  22. Stefan Bürk voted on patch set 8 CR +1 10/29/22, 11:24

  23. Stefan Bürk voted on patch set 8 V +2 CR +2 10/29/22, 12:28

  24. Stefan Bürk merged patch set 9 10/29/22, 12:28