Review main Merged Breaking

75881[!!!][TASK] Remove jQuery from FormEngine auto-suggest

Andreas Kienast CR +2 V +2 Hard +514 −221 updated 09/29/22, 12:47

Commit message

This patch migrates the auto-suggest feature used in FormEngine to a
custom implementation incorporating web components.
A user may navigate through the result list with the keyboard's arrow
keys and select an item with the "Enter" key.

In the same run, the JavaScript library `devbridge-autocomplete` is
removed as it is not used anymore within TYPO3, along with its
associated CSS definitions.

As the web component approach allows us more flexibility and to maintain
a consistent look & feel of the backend, some properties were removed
from the suggest wizard's items.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1317

  1. Andreas Kienast uploaded patch set 1 09/27/22, 18:55

  2. core-ci voted on patch set 1 V +1 09/27/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31613

  3. Andreas Kienast uploaded patch set 2 09/28/22, 07:49

  4. Andreas Kienast commented on patch set 2 CR -1 09/28/22, 07:54

    lang labels are missing
  5. Andreas Kienast uploaded patch set 3 09/28/22, 08:21

  6. Andreas Kienast commented on patch set 3 V -1 09/28/22, 08:58

    Some test crashes so big that phpunit halts.
  7. Andreas Kienast uploaded patch set 4 09/28/22, 09:02

  8. core-ci voted on patch set 4 V +1 09/28/22, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31643

  9. Benni Mack voted on patch set 4 CR +1 09/28/22, 10:04

  10. Andreas Kienast uploaded patch set 5 09/28/22, 13:44

  11. core-ci voted on patch set 5 V +1 09/28/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31658

  12. Andreas Kienast uploaded patch set 6 09/29/22, 07:41

  13. core-ci voted on patch set 6 V +1 09/29/22, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31690

  14. Frank Nägler voted on patch set 6 V +1 CR +1 09/29/22, 11:01

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 09/29/22, 12:46

  16. Andreas Kienast voted on patch set 6 V +2 CR +2 09/29/22, 12:47

  17. Andreas Kienast merged patch set 7 09/29/22, 12:47