75882[BUGFIX] Allow language parameter for error handling
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2637
Show 712 earlier messages
-
Guido Schmechel uploaded patch set 1 09/27/22, 19:57
-
core-ci voted on patch set 1 V -1 09/27/22, 20:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31615
-
Guido Schmechel uploaded patch set 2 09/27/22, 20:08
-
core-ci voted on patch set 2 V +1 09/27/22, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31616
-
Guido Schmechel voted on patch set 2 CR -1 09/27/22, 20:17
-
Benni Mack commented on patch set 2 03/24/23, 11:47
Re-read the issue, this is a bug, not a feature -
Benni Mack updated the commit message in patch set 3
CR -1V +107/04/23, 20:11 -
core-ci voted on patch set 3 V -1 07/04/23, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43435
-
Benni Mack rebased onto patch set 4
V -107/05/23, 07:13 -
Benni Mack updated the commit message in patch set 5 07/05/23, 07:13
-
core-ci voted on patch set 4 V +1 07/05/23, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43456
-
core-ci voted on patch set 5 V +1 07/05/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43457
-
Jörg Bösche voted on patch set 5 CR +1 07/07/23, 10:51
-
Anja Leichsenring commented on patch set 5 CR -1 08/02/23, 15:11
PageContentErrorHandler.php:160is parameters['language'] absolutely always available? I'd say we need a ?? 0 here to avoid array key access failures. -
Guido Schmechel uploaded patch set 6
CR +1V +108/03/23, 19:02 -
core-ci voted on patch set 6 V +1 08/03/23, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44947
-
Guido Schmechel commented on patch set 6 08/03/23, 19:20
PageContentErrorHandler.php:160ReplyDone -
Henning Liebe commented on patch set 6 CR -1 08/03/23, 19:34
PageContentErrorHandler.php:140should be done in else block. -
Anja Leichsenring commented on patch set 6 08/04/23, 11:07
PageContentErrorHandler.php:140Replywhat for? The if-block will return, so no else necessary, because code flow will be stopped. -
Henning Liebe commented on patch set 6 08/05/23, 07:51
PageContentErrorHandler.php:140ReplyI meant the else block below where $parameters is used -
Guido Schmechel commented on patch set 6 08/07/23, 12:20
PageContentErrorHandler.php:140ReplyAck -
Guido Schmechel uploaded patch set 7
CR -1V +108/07/23, 20:51 -
core-ci voted on patch set 7 V +1 08/07/23, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45203
-
Benni Mack rebased onto patch set 8
V +111/01/23, 21:59 -
core-ci voted on patch set 8 V +1 11/01/23, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48466
-
Patrick Schriner commented on patch set 8 11/09/23, 08:06
Minor nit-pick: as in https://review.typo3.org/c/Packages/TYPO3.CMS/+/79207 the parameter is "_language" everywhere else - even though it seems a bit odd, I'd rather have to remember that it's "_language"? -
Benni Mack commented on patch set 9
V +101/31/24, 07:00Published edit on patch set 8. -
Benni Mack updated the commit message in patch set 10 01/31/24, 07:02
-
core-ci voted on patch set 9 V -1 01/31/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52532
-
core-ci voted on patch set 10 V -1 01/31/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52533
-
Patrick Schriner commented on patch set 10 02/06/24, 15:55
It's "working", but I don't get the use case. I can only trigger it if: I disable a specific language ("Visible in frontend" in Sites module) If a language is enabled, that will always be used - even if the error page is not enabled in that language (which makes little sense: you cannot e.g. define an English error page as the fall back for danish) Maybe I'm missing something - how can I reproduce this to make sense? -
Benni Mack wrote 03/04/24, 09:45
Removed cc Benni Mack. -
Anja Leichsenring wrote 07/31/24, 18:19
Removed reviewer Anja Leichsenring. -
Benni Mack updated the commit message in patch set 11
V -110/18/24, 13:39 -
Benni Mack rebased onto patch set 12 04/11/25, 21:12
-
core-ci voted on patch set 12 V +1 04/11/25, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77584
-
Guido Schmechel abandoned the change 04/12/25, 11:52
The patch is abandoned because the edge case is no longer reproducible in version 11.5 and it is solved correctly. As there was generally little interest and this logic could also be solved with a separate ErrorHandler, the issue is now closed.