Review main Merged

75885[TASK] Move root css variables to dedicated file

Benjamin Kott CR +2 V +2 Normal +68 −68 updated 09/28/22, 11:38

Commit message

The inclusion of the global CSS variables into the
SCSS variables were flawed from the very beginning.
The include resulted in multiple unwanted occurrences
of these variables produced by the current architecture
of the SCSS files used in the backend.

It has been a known issue and accepted issue from the
start, since we did not have a plan yet to handle them.

The CSS variables are moved to a dedicated root file
that is part of the minimal setup. The minimal setup
is meant to be standalone and only included once
per page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 56

  1. Benjamin Kott uploaded patch set 1 09/28/22, 11:00

  2. core-ci voted on patch set 1 V +1 09/28/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31648

  3. Markus Klein voted on patch set 1 V +1 CR +1 09/28/22, 11:32

  4. Georg Ringer voted on patch set 1 V +1 CR +1 09/28/22, 11:37

  5. Benni Mack voted on patch set 1 V +2 CR +2 09/28/22, 11:38

  6. Benni Mack merged patch set 2 09/28/22, 11:38