Review main Merged

75887[TASK] Do not use jQuery and jQuery UI in page module drag&drop

Andreas Kienast CR +2 V +2 Hard +149 −155 updated 10/04/22, 19:50

Commit message

This patch reimplements the drag&drop functionality in the page module
with interactjs and thus removes the need of jQuery and jQuery UI, which
is removed.

Due to the fact the iframe is not scrollable, but the module body is
scrollable, we need to intercept the position calculation at some
places.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1523

  1. Andreas Kienast uploaded patch set 1 09/28/22, 13:42

  2. core-ci voted on patch set 1 V +1 09/28/22, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31656

  3. Andreas Kienast uploaded patch set 2 09/28/22, 15:45

  4. core-ci voted on patch set 2 V +1 09/28/22, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31667

  5. Andreas Kienast uploaded patch set 3 09/29/22, 10:14

  6. core-ci voted on patch set 3 V +1 09/29/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31695

  7. Andreas Kienast uploaded patch set 4 09/29/22, 10:27

  8. core-ci voted on patch set 4 V +1 09/29/22, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31697

  9. Frank Nägler commented on patch set 4 V -1 09/29/22, 11:13

    When I drag an element to the margins (top or bottom), the browser doesn't scroll up or down. Accordingly, drag&drop can no longer be used or only within the current visible area.
  10. Andreas Kienast uploaded patch set 5 09/29/22, 15:55

  11. core-ci voted on patch set 5 V +1 09/29/22, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31714

  12. Andreas Kienast uploaded patch set 6 09/30/22, 12:52

  13. core-ci voted on patch set 6 V +1 09/30/22, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31749

  14. Georg Ringer commented on patch set 6 V -1 10/01/22, 19:46

    there is a change in behavior as now the drop area is *below* the button "+ content". previously it was *instead* of it. this is IMO bad as it moves all content elements some pixels below after pressing the cursor
  15. Andreas Kienast commented on patch set 6 10/02/22, 13:08

    Reply

    Ack, thanks for reporting.
  16. Andreas Kienast uploaded patch set 7 10/02/22, 13:45

  17. core-ci voted on patch set 7 V +1 10/02/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31877

  18. Andreas Kienast rebased onto patch set 8 10/04/22, 18:22

  19. core-ci voted on patch set 8 V +1 10/04/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32007

  20. Georg Ringer voted on patch set 8 V +1 CR +1 10/04/22, 19:06

  21. Christian Kuhn voted on patch set 8 V +1 CR +1 10/04/22, 19:49

  22. Andreas Kienast voted on patch set 8 V +2 CR +2 10/04/22, 19:50

  23. Andreas Kienast merged patch set 9 10/04/22, 19:50