Review main Merged

75890[BUGFIX] Use more intuitive shortcut to open the live search

Andreas Kienast CR +2 V +2 Normal +69 −72 updated 09/29/22, 12:31

Commit message

The UX team discusses internally whether the existing shortcut to open
the live search (Shift+Shift) introduced in #98348 is counter-intuitive
for regular editors or not.

Common sense seems to be Ctrl/Cmd+K to open the search in several
applications and websites (Discord, Slack, and even in Chrome), so the
keyboard shortcut should be changed.

If any modal is already open, the new keystroke is not caught and any
default browser behavior is kept.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Annett Jähnichen +1
    • Frank Nägler +1
    • Christian Kuhn +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 1618

  1. Andreas Kienast uploaded patch set 1 09/29/22, 06:33

  2. Andreas Kienast updated the commit message in patch set 2 09/29/22, 06:35

  3. core-ci voted on patch set 1 V +1 09/29/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31687

  4. core-ci voted on patch set 2 V +1 09/29/22, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31688

  5. Stefan Froemken voted on patch set 2 V +1 CR +1 09/29/22, 06:56

  6. Frank Nägler commented on patch set 2 V +1 CR +1 09/29/22, 07:51

    tested on Mac with Chrome, Firefox and Safari, works great.
  7. Annett Jähnichen commented on patch set 2 V +1 09/29/22, 08:02

    Tested Cmd + K on Mac
  8. Simon Schaufelberger commented on patch set 2 09/29/22, 08:44

    why not Ctrl + F? that I also the default for many programs to open the search
  9. Andreas Kienast commented on patch set 2 09/29/22, 08:52

    Reply

    Ctrl+F is a common browser shortcut that's also helpful and usable in the TYPO3 backend.
  10. Simon Schaufelberger commented on patch set 2 09/29/22, 11:46

    Reply

    Ctrl + K puts the focus in the address bar which is probably not so often used.
  11. Simon Schaufelberger commented on patch set 2 09/29/22, 11:47

    Reply

    so would you add Ctrl + F as well?
  12. Andreas Kienast commented on patch set 2 09/29/22, 12:00

    Reply

    No, I would still not use Ctrl+F. I'm aware that Ctrl+K puts the focus on the browser's address bar, if supported, that's the reason I ignore the interception once a modal is open to give the user still the possibility to use that shortcut.
  13. Simon Schaufelberger commented on patch set 2 09/29/22, 12:27

    Reply

    Ack
  14. Frank Nägler commented on patch set 2 09/29/22, 12:29

    Reply

    Another reason for ctrl+l / cmg+k is, that it is a kind of common standard in other apps. For example, see slack, discord, and a lot more.
  15. Christian Kuhn voted on patch set 2 V +1 CR +1 09/29/22, 12:29

  16. Christian Kuhn commented on patch set 2 09/29/22, 12:30

    Reply

    Done
  17. Andreas Kienast voted on patch set 2 V +2 CR +2 09/29/22, 12:31

  18. Andreas Kienast merged patch set 3 09/29/22, 12:31