75890[BUGFIX] Use more intuitive shortcut to open the live search
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Christian Kuhn +1
- Stefan Froemken +1
-
Verified V +2 Done
- Andreas Kienast +2
- Annett Jähnichen +1
- Frank Nägler +1
- Christian Kuhn +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 2
Files 9
- Build/Sources/TypeScript/backend/live-search/double-shift-trigger.tsdeleted+0 −39
- Build/Sources/TypeScript/backend/live-search/live-search-shortcut.tsnew+41 −0
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+8 −14
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/double-shift-trigger.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/live-search-shortcut.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98348-LiveSearchMovedIntoModalWindow.rst+3 −2
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+2 −2
Review log 1618
-
Andreas Kienast uploaded patch set 1 09/29/22, 06:33
-
Andreas Kienast updated the commit message in patch set 2 09/29/22, 06:35
-
core-ci voted on patch set 1 V +1 09/29/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31687
-
core-ci voted on patch set 2 V +1 09/29/22, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31688
-
Stefan Froemken voted on patch set 2 V +1 CR +1 09/29/22, 06:56
-
Frank Nägler commented on patch set 2 V +1 CR +1 09/29/22, 07:51
tested on Mac with Chrome, Firefox and Safari, works great. -
Annett Jähnichen commented on patch set 2 V +1 09/29/22, 08:02
Tested Cmd + K on Mac -
Simon Schaufelberger commented on patch set 2 09/29/22, 08:44
why not Ctrl + F? that I also the default for many programs to open the search -
Andreas Kienast commented on patch set 2 09/29/22, 08:52
Reply
Ctrl+F is a common browser shortcut that's also helpful and usable in the TYPO3 backend. -
Simon Schaufelberger commented on patch set 2 09/29/22, 11:46
Reply
Ctrl + K puts the focus in the address bar which is probably not so often used. -
Simon Schaufelberger commented on patch set 2 09/29/22, 11:47
Reply
so would you add Ctrl + F as well? -
Andreas Kienast commented on patch set 2 09/29/22, 12:00
Reply
No, I would still not use Ctrl+F. I'm aware that Ctrl+K puts the focus on the browser's address bar, if supported, that's the reason I ignore the interception once a modal is open to give the user still the possibility to use that shortcut. -
Simon Schaufelberger commented on patch set 2 09/29/22, 12:27
Reply
Ack -
Frank Nägler commented on patch set 2 09/29/22, 12:29
Reply
Another reason for ctrl+l / cmg+k is, that it is a kind of common standard in other apps. For example, see slack, discord, and a lot more. -
Christian Kuhn voted on patch set 2 V +1 CR +1 09/29/22, 12:29
-
Christian Kuhn commented on patch set 2 09/29/22, 12:30
Reply
Done -
Andreas Kienast voted on patch set 2 V +2 CR +2 09/29/22, 12:31
-
Andreas Kienast merged patch set 3 09/29/22, 12:31