Review main Merged

75912[TASK] No default type in ApplicationType

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 09/29/22, 10:27

Commit message

Property $type is set by a required
constructor argument and needs no default.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 09/29/22, 10:12

  2. Christian Kuhn updated the commit message in patch set 2 09/29/22, 10:14

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 09/29/22, 10:16

  4. Christian Kuhn commented on patch set 2 09/29/22, 10:17

    will merge as no-brainer when green.
  5. core-ci voted on patch set 1 V +1 09/29/22, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31694

  6. core-ci voted on patch set 2 V +1 09/29/22, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31696

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 09/29/22, 10:27

  8. Christian Kuhn merged patch set 3 09/29/22, 10:27