Review main Merged

75915[TASK] Avoid negative pid's in SQL schema

Christian Kuhn CR +2 V +2 Normal +25 −26 updated 09/29/22, 20:47

Commit message

Field 'pid' in TCA tables should not allow
negative integer values anymore since "pid -1"
values have been removed from workspaces in v10.

The patch changes the field to an unsigned int.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1115

  1. Christian Kuhn uploaded patch set 1 09/29/22, 18:49

  2. core-ci voted on patch set 1 V -1 09/29/22, 18:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31715

  3. Christian Kuhn uploaded patch set 2 09/29/22, 19:07

  4. core-ci voted on patch set 2 V +1 09/29/22, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31716

  5. Christian Kuhn updated the commit message in patch set 3 09/29/22, 19:20

  6. core-ci voted on patch set 3 V +1 09/29/22, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31717

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 09/29/22, 19:29

  8. Benni Mack commented on patch set 3 09/29/22, 20:19

    I know this is on top, but can we create an Important.rst so people understand why their Database Compare tool shows so many changed fields now? :)
  9. Christian Kuhn commented on patch set 3 09/29/22, 20:21

    sure. will do.

    Reply

    sure. will do.
  10. Christian Kuhn uploaded patch set 4 09/29/22, 20:31

  11. Stefan Bürk commented on patch set 4 V +1 CR +1 09/29/22, 20:33

    Reply

    Good point with the Important.rst.
  12. Benni Mack voted on patch set 4 V +1 CR +1 09/29/22, 20:36

  13. core-ci voted on patch set 4 V +1 09/29/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31719

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 09/29/22, 20:47

  15. Christian Kuhn merged patch set 5 09/29/22, 20:47