Review main Merged

75917[TASK] Enforce TYPO3 Composer Installers package v5

Benni Mack CR +2 V +2 Normal +45 −16 updated 10/01/22, 13:42

Commit message

Composer-based installations will now have their
extensions within composers' vendor folder
instead of typo3/sysext/ and typo3conf/ext/.

This way, all non-public files are moved outside
the document root (ideally), while public files
within extensions are symlinked to public/_assets/.

TYPO3 will then resolve "EXT:" syntax depending
on public / private folders to their respective
locations.

Used commands:
- composer req "typo3/cms-composer-installers:^5.0"
- composer req "typo3/cms-composer-installers:^5.0" --no-update -d typo3/sysext/core

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1319

  1. Benni Mack uploaded patch set 1 09/29/22, 23:12

  2. core-ci voted on patch set 1 V -1 09/29/22, 23:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31724

  3. Benjamin Franzke commented on patch set 1 09/30/22, 13:05

    would love too see that, together with: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75924 With both things applies we can *rely* on the fact that composer mode doesn't require cache-bust parameters appended to filenames. Would be great for importmaps, which could then be reduced in size.
  4. Benjamin Franzke uploaded patch set 2 09/30/22, 14:48

  5. Benjamin Franzke voted on patch set 2 V +1 CR +1 09/30/22, 14:50

  6. core-ci voted on patch set 2 V -1 09/30/22, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31760

  7. Helmut Hummel uploaded patch set 3 09/30/22, 14:54

  8. core-ci voted on patch set 3 V -1 09/30/22, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31761

  9. Benni Mack uploaded patch set 4 09/30/22, 16:03

  10. core-ci voted on patch set 4 V -1 09/30/22, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31765

  11. Benjamin Franzke uploaded patch set 5 10/01/22, 04:20

  12. core-ci voted on patch set 5 V +1 10/01/22, 04:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31795

  13. Benjamin Franzke uploaded patch set 6 10/01/22, 04:40

  14. Benjamin Franzke voted on patch set 6 V +1 CR +1 10/01/22, 04:40

  15. core-ci voted on patch set 6 V +1 10/01/22, 04:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31796

  16. Oliver Hader voted on patch set 6 CR +1 10/01/22, 07:40

  17. Oli Bartsch voted on patch set 6 V +1 CR +1 10/01/22, 11:54

  18. Benni Mack commented on patch set 6 V +2 CR +2 10/01/22, 13:40

    FYI: We have to add the symlink due to some problems with styleguide and Testing Framework (styleguide is a composer dependency, but testing framework expects styleguide to be in the "legacy" place in typo3conf/ext/styleguide).
  19. Benni Mack merged patch set 7 10/01/22, 13:42