Review main Merged

75920[TASK] Update rollup and optimize build resolving

Benni Mack CR +2 V +2 Expert +1274 −144 updated 09/30/22, 11:18

Commit message

This change updates rollup and installs
some further devDependencies we need
for optimizations in CKEditor5.

Used command:
 cd Build/
 npm install --save-dev \
    rollup@^2.79.1 \
    @rollup/plugin-node-resolve \
    rollup-plugin-postcss \
    rollup-plugin-svg \
    rollup-plugin-terser
 grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 56

  1. Benni Mack uploaded patch set 1 09/30/22, 10:14

  2. Oliver Hader voted on patch set 1 CR +1 09/30/22, 10:16

  3. core-ci voted on patch set 1 V +1 09/30/22, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31739

  4. Georg Ringer voted on patch set 1 V +1 CR +1 09/30/22, 11:09

  5. Benni Mack voted on patch set 1 V +2 CR +2 09/30/22, 11:18

  6. Benni Mack merged patch set 2 09/30/22, 11:18