Review main Merged

75921[TASK] Align UI of the DB check module

Annett Jähnichen CR +2 V +2 Normal +2 −66 updated 10/02/22, 07:13

Commit message

DB Check seems to be the only module in backend
that uses an Overview view for displaying the functions.
Other modules have a default function that is loaded.

Replace overview page by loading Manage Reference Index as default function,
as this is probably where the least loading overhead occurs.

* Remove DatabaseIntegrityController->overviewAction
* Remove IntegrityOverview.html
* Remove Test seeOverview

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1924

  1. Annett Jähnichen uploaded patch set 1 09/30/22, 10:30

  2. core-ci voted on patch set 1 V -1 09/30/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31740

  3. Annett Jähnichen uploaded patch set 2 09/30/22, 13:49

  4. core-ci voted on patch set 2 V +1 09/30/22, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31758

  5. Benni Mack commented on patch set 2 09/30/22, 15:50

    This change is ready for review.

    DatabaseIntegrityController.php:231

    I think you can get rid of this function, it is protected and within the Controller (which is internal) so please remove the whole method.
  6. Annett Jähnichen uploaded patch set 3 10/01/22, 12:15

  7. core-ci voted on patch set 3 V +1 10/01/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31817

  8. Annett Jähnichen commented on patch set 3 10/01/22, 12:29

    DatabaseIntegrityController.php:231 Reply

    Thx Benni for your feedback. I have removed the method and deprecation .rst now.
  9. Benni Mack voted on patch set 3 CR +1 10/01/22, 13:38

  10. Chris Müller voted on patch set 3 V +1 CR +1 10/01/22, 13:46

  11. Benni Mack commented on patch set 3 V +1 10/01/22, 13:57

    ready to merge Annett
  12. Christian Kuhn commented on patch set 3 CR -1 10/01/22, 14:03

    let's clean up the xlf labels, too.

    DatabaseIntegrityController.php:92

    could you have a look if these labels are still used, also those referenced in the deleted fluid template file? if no longer used, they should be removed from the .xlf files.
  13. Annett Jähnichen uploaded patch set 4 10/01/22, 14:25

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 10/01/22, 14:28

  15. Christian Kuhn commented on patch set 4 10/01/22, 14:29

    DatabaseIntegrityController.php:92 Reply

    Done
  16. core-ci voted on patch set 4 V +1 10/01/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31826

  17. Annett Jähnichen uploaded patch set 5 10/01/22, 14:40

  18. Annett Jähnichen commented on patch set 5 10/01/22, 14:41

    DatabaseIntegrityController.php:92 Reply

    Sry, forgot that, Remove menuTitle and title the last one seems to be used only for fluid template.
  19. Christian Kuhn voted on patch set 5 V +1 CR +1 10/01/22, 14:44

  20. core-ci voted on patch set 5 V +1 10/01/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31828

  21. Georg Ringer voted on patch set 5 V +1 CR +1 10/01/22, 19:01

  22. Benni Mack commented on patch set 5 V +1 CR +1 10/01/22, 21:41

    now let's wait for annett to merge :)
  23. Annett Jähnichen voted on patch set 5 V +2 CR +2 10/02/22, 07:12

  24. Annett Jähnichen merged patch set 6 10/02/22, 07:13