75921[TASK] Align UI of the DB check module
Commit message
Review
-
Code review CR +2 Done
- Annett Jähnichen +2
- Georg Ringer +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Annett Jähnichen +2
- Georg Ringer +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Tests/Acceptance/Application/DbCheck/DbCheckModuleCest.php+0 −12
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php5+2 −23
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+0 −6
- typo3/sysext/lowlevel/Resources/Private/Templates/IntegrityOverview.htmldeleted+0 −25
Review log 1924
-
Annett Jähnichen uploaded patch set 1 09/30/22, 10:30
-
core-ci voted on patch set 1 V -1 09/30/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31740
-
Annett Jähnichen uploaded patch set 2 09/30/22, 13:49
-
core-ci voted on patch set 2 V +1 09/30/22, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31758
-
Benni Mack commented on patch set 2 09/30/22, 15:50
This change is ready for review.DatabaseIntegrityController.php:231I think you can get rid of this function, it is protected and within the Controller (which is internal) so please remove the whole method. -
Annett Jähnichen uploaded patch set 3 10/01/22, 12:15
-
core-ci voted on patch set 3 V +1 10/01/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31817
-
Annett Jähnichen commented on patch set 3 10/01/22, 12:29
DatabaseIntegrityController.php:231ReplyThx Benni for your feedback. I have removed the method and deprecation .rst now. -
Benni Mack voted on patch set 3 CR +1 10/01/22, 13:38
-
Chris Müller voted on patch set 3 V +1 CR +1 10/01/22, 13:46
-
Benni Mack commented on patch set 3 V +1 10/01/22, 13:57
ready to merge Annett -
Christian Kuhn commented on patch set 3 CR -1 10/01/22, 14:03
let's clean up the xlf labels, too.DatabaseIntegrityController.php:92could you have a look if these labels are still used, also those referenced in the deleted fluid template file? if no longer used, they should be removed from the .xlf files. -
Annett Jähnichen uploaded patch set 4 10/01/22, 14:25
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/01/22, 14:28
-
Christian Kuhn commented on patch set 4 10/01/22, 14:29
DatabaseIntegrityController.php:92ReplyDone -
core-ci voted on patch set 4 V +1 10/01/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31826
-
Annett Jähnichen uploaded patch set 5 10/01/22, 14:40
-
Annett Jähnichen commented on patch set 5 10/01/22, 14:41
DatabaseIntegrityController.php:92ReplySry, forgot that, Remove menuTitle and title the last one seems to be used only for fluid template. -
Christian Kuhn voted on patch set 5 V +1 CR +1 10/01/22, 14:44
-
core-ci voted on patch set 5 V +1 10/01/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31828
-
Georg Ringer voted on patch set 5 V +1 CR +1 10/01/22, 19:01
-
Benni Mack commented on patch set 5 V +1 CR +1 10/01/22, 21:41
now let's wait for annett to merge :) -
Annett Jähnichen voted on patch set 5 V +2 CR +2 10/02/22, 07:12
-
Annett Jähnichen merged patch set 6 10/02/22, 07:13