Review main Merged

75926[BUGFIX] Correct "additionalParams" handling in PageViewHelpers

Chris Müller CR +2 V +2 Easy +20 −2 updated 10/01/22, 09:17

Commit message

ViewHelpers f:link.page and f:uri.page in non-Extbase
context don't handle "additionalParams" correctly
since #98484, leading to a PHP warning.

Handle that argument correctly and add some tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1216

  1. Chris Müller uploaded patch set 1 09/30/22, 19:07

  2. core-ci voted on patch set 1 V +1 09/30/22, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31766

  3. Christian Kuhn commented on patch set 1 CR -1 10/01/22, 08:25

    will add a functional test
  4. Christian Kuhn uploaded patch set 2 10/01/22, 08:30

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/01/22, 08:31

  6. Christian Kuhn updated the commit message in patch set 3 10/01/22, 08:32

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 10/01/22, 08:33

  8. Benni Mack voted on patch set 3 V +1 CR +1 10/01/22, 08:39

  9. core-ci voted on patch set 2 V -1 10/01/22, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31804

  10. core-ci voted on patch set 3 V -1 10/01/22, 08:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31805

  11. Christian Kuhn uploaded patch set 4 10/01/22, 08:45

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 10/01/22, 08:45

  13. core-ci voted on patch set 4 V +1 10/01/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31808

  14. Benni Mack voted on patch set 4 V +1 CR +1 10/01/22, 09:04

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 10/01/22, 09:17

  16. Christian Kuhn merged patch set 5 10/01/22, 09:17