Review main Merged Breaking

75928[!!!][FEATURE] Introduce PSR-14 event for DatabaseRecordList

Benni Mack CR +2 V +2 Hard +242 −103 updated 10/02/22, 10:19

Commit message

This change introduces a new PSR-14 event
"ModifyDatabaseQueryForRecordListingEvent"
which serves as a successor for various hooks:

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/class.db_list_extra.inc']['getTable']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList']['modifyQuery']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList']['makeSearchStringConstraints']

The interface "RecordListGetTableHookInterface"
is not in use anymore and is marked as deprecated.

In addition, several methods in DatabaseRecordList
now have a different method signature:

* DatabaseRecordList->getTable() without $pageId and $additionalConstraints
* DatabaseRecordList->getQueryBuilder() without the "pageId" argument
* DatabaseRecordList->makeSearchString() now marked as protected

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1115

  1. Benni Mack uploaded patch set 1 09/30/22, 23:41

  2. core-ci voted on patch set 1 V -1 09/30/22, 23:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31787

  3. Benni Mack uploaded patch set 2 10/01/22, 08:42

  4. core-ci voted on patch set 2 V -1 10/01/22, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31806

  5. Benni Mack commented on patch set 3 10/01/22, 09:53

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 10/01/22, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31810

  7. Benni Mack uploaded patch set 4 10/01/22, 13:51

  8. core-ci voted on patch set 4 V +1 10/01/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31820

  9. Georg Ringer commented on patch set 4 10/01/22, 19:08

    should we mention changed DatabaseRecordList::getTable as it is public but marked as internal?
  10. Benni Mack commented on patch set 4 10/01/22, 21:36

    Reply

    is it marked as internal? Did not see this...
  11. Georg Ringer commented on patch set 4 V +1 CR +1 10/02/22, 07:25

    Yes, full class
  12. Benni Mack commented on patch set 4 10/02/22, 07:55

    Reply

    good point. so no need to document the method signatures. should I remove them from Extenion Scanner and RST? Might be useful for rector folks to make Rules for it-
  13. Oli Bartsch voted on patch set 4 V +1 CR +1 10/02/22, 10:19

  14. Benni Mack voted on patch set 4 V +2 CR +2 10/02/22, 10:19

  15. Benni Mack merged patch set 5 10/02/22, 10:19