75928[!!!][FEATURE] Introduce PSR-14 event for DatabaseRecordList
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Controller/RecordListController.php+4 −3
- typo3/sysext/backend/Classes/Controller/RecordListDownloadController.php+0 −1
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+25 −89
- typo3/sysext/backend/Classes/RecordList/DownloadRecordList.php+4 −6
- typo3/sysext/backend/Classes/RecordList/RecordListGetTableHookInterface.php+4 −0
- typo3/sysext/backend/Classes/View/Event/ModifyDatabaseQueryForRecordListingEvent.phpnew+79 −0
- typo3/sysext/backend/Tests/Functional/RecordList/DownloadRecordListTest.php+4 −4
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98490-VariousHooksAndMethodsChangedInDatabaseRecordList.rstnew+53 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98490-PSR-14EventToAlterTheRecordsRenderedInRecordListings.rstnew+26 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+18 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+12 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+8 −0
Review log 1115
-
Benni Mack uploaded patch set 1 09/30/22, 23:41
-
core-ci voted on patch set 1 V -1 09/30/22, 23:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31787
-
Benni Mack uploaded patch set 2 10/01/22, 08:42
-
core-ci voted on patch set 2 V -1 10/01/22, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31806
-
Benni Mack commented on patch set 3 10/01/22, 09:53
Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 10/01/22, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31810
-
Benni Mack uploaded patch set 4 10/01/22, 13:51
-
core-ci voted on patch set 4 V +1 10/01/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31820
-
Georg Ringer commented on patch set 4 10/01/22, 19:08
should we mention changed DatabaseRecordList::getTable as it is public but marked as internal? -
Benni Mack commented on patch set 4 10/01/22, 21:36
Reply
is it marked as internal? Did not see this... -
Georg Ringer commented on patch set 4 V +1 CR +1 10/02/22, 07:25
Yes, full class -
Benni Mack commented on patch set 4 10/02/22, 07:55
Reply
good point. so no need to document the method signatures. should I remove them from Extenion Scanner and RST? Might be useful for rector folks to make Rules for it- -
Oli Bartsch voted on patch set 4 V +1 CR +1 10/02/22, 10:19
-
Benni Mack voted on patch set 4 V +2 CR +2 10/02/22, 10:19
-
Benni Mack merged patch set 5 10/02/22, 10:19