Review main Merged

75930[TASK] Mitigate browser "spell jacking" in form elements

Oliver Hader CR +2 V +2 Easy +18 −13 updated 10/16/22, 10:12

Commit message

Having manually(!) enabled "enhanced spell checking" in browsers,
can lead to scenarios where password data is sent to remote services
which actually take care of the spell checking.

see https://www.otto-js.com/news/article/chrome-and-edge-enhanced-spellcheck-features-expose-pii-even-your-passwords

Since this issue is caused by browsers and the determination of
"confidentiality" is fuzzy here, this issue is handled in public.

Following changes have been applied:
+ forms dealing mainly with credentials, as well as all forms in
  ext:install  have been adjusted to `<form ... spellcheck="false">`
+ other password form elements, including TCA type `password` have
  been adjusted to `<input type="password" ... spellcheck="false">`

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1213

  1. Oliver Hader uploaded patch set 1 10/01/22, 10:08

  2. Benni Mack commented on patch set 1 10/01/22, 10:09

    We could add this feature to f:form VHs and also mark it as a new feature?
  3. core-ci voted on patch set 1 V +1 10/01/22, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31811

  4. Oliver Hader commented on patch set 1 10/01/22, 10:20

    This is probably something for v11 & v10 as well - however e.g. `PasswortElement` does not exist there... so it would be a bit "different".
  5. Oliver Hader commented on patch set 1 10/01/22, 10:20

    main, 11, 10?
  6. Torben Hansen voted on patch set 1 CR +1 10/01/22, 10:52

  7. Georg Ringer voted on patch set 1 V +1 CR +1 10/01/22, 19:23

  8. Benjamin Franzke voted on patch set 1 V +2 CR +2 10/01/22, 19:58

  9. Benjamin Franzke merged patch set 2 10/01/22, 19:58

  10. Oliver Hader commented on patch set 2 10/03/22, 08:04

    I back-ported this to TYPO3 v11.5 as well: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75946
  11. Oliver Hader commented on patch set 2 10/16/22, 10:01

    Login.html:49

    see #98625
  12. Oliver Hader commented on patch set 2 10/16/22, 10:02

    Reply

    Done
  13. Oliver Hader commented on patch set 2 10/16/22, 10:12