Review main Merged

75938[DOCS] Improve changelog for v12 release

Lina Wolf CR +2 V +2 Nightmare +1542 −1514 updated 10/03/22, 18:55

Commit message

- Add cross references for changelog files
- Remove additional empty lines
- Rename core -> Core
- Rename composer -> Composer
- Fix grammar: extensions' -> extension's
- Indent lists with 4 spaces (including the asterisk character)
- Indent code-blocks with 4 spaces (including the two dots)
- Simplify code examples
- Fix some typos and simplify sentences along the way

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +2
    • Chris Müller +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +2
    • Chris Müller +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 281

Show 261 more files

Review log 3549

Show 1624 earlier messages
  1. Lina Wolf uploaded patch set 1 10/02/22, 10:26

  2. core-ci voted on patch set 1 V +1 10/02/22, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31867

  3. Lina Wolf uploaded patch set 2 10/02/22, 10:43

  4. Benni Mack commented on patch set 2 10/02/22, 10:48

    Thank you, Lina!
  5. core-ci voted on patch set 2 V +1 10/02/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31868

  6. Chris Müller commented on patch set 2 CR -1 10/02/22, 11:31

    Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst:47

    When indenting the directive, the code should also be indentend.

    Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst:59

    Here too.

    Breaking-96263-RemoveJQueryPromiseSupportForAJAXRequests.rst:36

    When the directive is indented, the code should also be indented.

    Breaking-96263-RemoveJQueryPromiseSupportForAJAXRequests.rst:52

    Here, too.

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:42

    When the directive is indented, the code should also be indented.

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:52

    Here, too.

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:64

    Here, too.

    Breaking-96575-UpdateToCodeMirror6.rst:44

    When the directive is indented, the code should also be indented.

    Breaking-96575-UpdateToCodeMirror6.rst:63

    Here, too.

    Breaking-97091-TSFE-clear_previewHasBeenRemoved.rst:31

    Please indent the code accordingly.

    Breaking-97816-TypoScriptSyntaxChanges.rst:63

    When the directive is indented, the code should also be indented. Please also remove the white space before the directive.

    Breaking-97816-TypoScriptSyntaxChanges.rst:81

    Here, too.

    Breaking-97816-TypoScriptSyntaxChanges.rst:96

    Here, too.

    Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst:20

    Third-party

    Breaking-98480-TCATableSys_templateIsNoLongerWorkspaceAware.rst:36

    sys_template is a tabloe, so I suggest :sql:

    Deprecation-96444-AuthModeSelectItemsKeywordsMovedToIndex5.rst:41

    When the directive is indented, the code should also be indented.

    Deprecation-96444-AuthModeSelectItemsKeywordsMovedToIndex5.rst:64

    Here, too.

    Deprecation-96568-RequireJSModulesInFormFramework.rst:38

    When the directive is indented, the code should also be indented.

    Deprecation-96568-RequireJSModulesInFormFramework.rst:53

    Here, too.

    Deprecation-97035-RequiredOptionInEvalKeyword.rst:41

    When the directive is indented, the code should also be indented.

    Deprecation-97035-RequiredOptionInEvalKeyword.rst:54

    When the directive is indented, the code should also be indented.

    Feature-87616-PSR-14EventForModifyingPageLinkGeneration.rst:29

    When the directive is indented, the code should also be indented.

    Feature-89917-InheritPageAccess.rst:53

    When the directive is indented, the code should also be indented.

    Feature-89917-InheritPageAccess.rst:75

    When the directive is indented, the code should also be indented.

    Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:29

    When the directive is indented, the code should also be indented.

    Feature-90994-MarkCurrentPageInFluid_styled_contentMenuContentElements.rst:19

    When the directive is indented, the code should also be indented.

    Feature-90994-MarkCurrentPageInFluid_styled_contentMenuContentElements.rst:33

    When the directive is indented, the code should also be indented.

    Feature-93494-NewPSR-14ModifyQueryForLiveSearchEvent.rst:27

    When the directive is indented, the code should also be indented.

    Feature-93494-NewPSR-14ModifyQueryForLiveSearchEvent.rst:36

    When the directive is indented, the code should also be indented.

    Feature-93689-PSR-14EventsOnSendingMessagesWithMailer.rst:36

    When the directive is indented, the code should also be indented.

    Feature-94117-ImproveExtbaseTypeConverterRegistration.rst:38

    When the directive is indented, the code should also be indented.

    Feature-94625-IntroduceSlidingWindowPagination.rst:33

    When the directive is indented, the code should also be indented.

    Feature-95486-AddAcceptArgument.rst:23

    When the directive is indented, the code should also be indented.

    Feature-96147-NewPSR-14RedirectWasHitEvent.rst:39

    When the directive is indented, the code should also be indented.

    Feature-96526-PSR-14EventForModifyingPageModuleContent.rst:29

    When the directive is indented, the code should also be indented.

    Feature-96733-NewBackendModuleRegistrationAPI.rst:241

    When the directive is indented, the code should also be indented.

    Feature-96800-AddSiteLanguageProcessor.rst:18

    When the directive is indented, the code should also be indented.

    Feature-96800-AddSiteLanguageProcessor.rst:32

    When the directive is indented, the code should also be indented.

    Feature-96806-PSR-14EventForModifyingButtonBar.rst:25

    When the directive is indented, the code should also be indented.

    Feature-96879-NewPSR-14EventModifyCacheLifetimeForPageEvent.rst:27

    When the directive is indented, the code should also be indented.

    Feature-97201-PSR-14EventForModifyingNewContentElementWizardItems.rst:69

    When the directive is indented, the code should also be indented.

    Feature-97231-PSR-14EventsForModifyingInlineElementControls.rst:44

    When the directive is indented, the code should also be indented.

    Feature-97544-PSR-14EventsForModifyingPreviewURIs.rst:74

    When the directive is indented, the code should also be indented.

    Feature-97816-TypoScriptSyntaxImprovements.rst:47

    When the directive is indented, the code should also be indented.

    Feature-97816-TypoScriptSyntaxImprovements.rst:76

    When the directive is indented, the code should also be indented.

    Feature-97816-TypoScriptSyntaxImprovements.rst:102

    When the directive is indented, the code should also be indented.

    Feature-97816-TypoScriptSyntaxImprovements.rst:119

    When the directive is indented, the code should also be indented.

    Feature-97816-TypoScriptSyntaxImprovements.rst:157

    When the directive is indented, the code should also be indented.
  7. Lina Wolf uploaded patch set 3 10/02/22, 13:51

  8. Lina Wolf uploaded patch set 4 10/02/22, 13:57

  9. Lina Wolf uploaded patch set 5 10/02/22, 14:01

  10. Lina Wolf commented on patch set 5 10/02/22, 14:02

    Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst:47 Reply

    Done

    Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst:59 Reply

    Done

    Breaking-96263-RemoveJQueryPromiseSupportForAJAXRequests.rst:36 Reply

    Done

    Breaking-96263-RemoveJQueryPromiseSupportForAJAXRequests.rst:52 Reply

    Done

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:42 Reply

    Done

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:52 Reply

    Done

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:64 Reply

    Done

    Breaking-96575-UpdateToCodeMirror6.rst:44 Reply

    Done

    Breaking-96575-UpdateToCodeMirror6.rst:63 Reply

    Done

    Breaking-97091-TSFE-clear_previewHasBeenRemoved.rst:31 Reply

    Done

    Breaking-97816-TypoScriptSyntaxChanges.rst:63 Reply

    Done

    Breaking-97816-TypoScriptSyntaxChanges.rst:81 Reply

    Done

    Breaking-97816-TypoScriptSyntaxChanges.rst:96 Reply

    Done

    Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst:20 Reply

    Done

    Breaking-98480-TCATableSys_templateIsNoLongerWorkspaceAware.rst:36 Reply

    Done

    Deprecation-96444-AuthModeSelectItemsKeywordsMovedToIndex5.rst:41 Reply

    Done

    Deprecation-96444-AuthModeSelectItemsKeywordsMovedToIndex5.rst:64 Reply

    Done

    Deprecation-96568-RequireJSModulesInFormFramework.rst:38 Reply

    Done

    Deprecation-96568-RequireJSModulesInFormFramework.rst:53 Reply

    Done

    Deprecation-97035-RequiredOptionInEvalKeyword.rst:41 Reply

    Done

    Deprecation-97035-RequiredOptionInEvalKeyword.rst:54 Reply

    Done

    Feature-87616-PSR-14EventForModifyingPageLinkGeneration.rst:29 Reply

    Done

    Feature-89917-InheritPageAccess.rst:53 Reply

    Done

    Feature-89917-InheritPageAccess.rst:75 Reply

    Done

    Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:29 Reply

    Done

    Feature-90994-MarkCurrentPageInFluid_styled_contentMenuContentElements.rst:19 Reply

    Done

    Feature-90994-MarkCurrentPageInFluid_styled_contentMenuContentElements.rst:33 Reply

    Done

    Feature-93494-NewPSR-14ModifyQueryForLiveSearchEvent.rst:27 Reply

    Done

    Feature-93494-NewPSR-14ModifyQueryForLiveSearchEvent.rst:36 Reply

    Done

    Feature-93689-PSR-14EventsOnSendingMessagesWithMailer.rst:36 Reply

    Done

    Feature-94117-ImproveExtbaseTypeConverterRegistration.rst:38 Reply

    Done

    Feature-94625-IntroduceSlidingWindowPagination.rst:33 Reply

    Done

    Feature-95486-AddAcceptArgument.rst:23 Reply

    Done

    Feature-96147-NewPSR-14RedirectWasHitEvent.rst:39 Reply

    Done

    Feature-96526-PSR-14EventForModifyingPageModuleContent.rst:29 Reply

    Done

    Feature-96733-NewBackendModuleRegistrationAPI.rst:241 Reply

    Done

    Feature-96800-AddSiteLanguageProcessor.rst:18 Reply

    Done

    Feature-96800-AddSiteLanguageProcessor.rst:32 Reply

    Done

    Feature-96806-PSR-14EventForModifyingButtonBar.rst:25 Reply

    Done

    Feature-96879-NewPSR-14EventModifyCacheLifetimeForPageEvent.rst:27 Reply

    Done

    Feature-97201-PSR-14EventForModifyingNewContentElementWizardItems.rst:69 Reply

    Done

    Feature-97231-PSR-14EventsForModifyingInlineElementControls.rst:44 Reply

    Done

    Feature-97544-PSR-14EventsForModifyingPreviewURIs.rst:74 Reply

    Done

    Feature-97816-TypoScriptSyntaxImprovements.rst:47 Reply

    Done

    Feature-97816-TypoScriptSyntaxImprovements.rst:76 Reply

    Done

    Feature-97816-TypoScriptSyntaxImprovements.rst:102 Reply

    Done

    Feature-97816-TypoScriptSyntaxImprovements.rst:119 Reply

    Done

    Feature-97816-TypoScriptSyntaxImprovements.rst:157 Reply

    Done
  11. core-ci voted on patch set 4 V +1 10/02/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31879

  12. core-ci voted on patch set 3 V -1 10/02/22, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31878

  13. core-ci voted on patch set 5 V +1 10/02/22, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31880

  14. Lina Wolf commented on patch set 5 10/02/22, 14:22

    You can use a Gitpod to render the changelog, see https://github.com/ochorocho/typo3-changelog-gitpod/blob/main/README.md
  15. Chris Müller uploaded patch set 6 10/02/22, 15:10

  16. core-ci voted on patch set 6 V +1 10/02/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31888

  17. Chris Müller uploaded patch set 7 10/02/22, 15:54

  18. core-ci voted on patch set 7 V +1 10/02/22, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31889

  19. Chris Müller uploaded patch set 8 10/02/22, 16:37

  20. core-ci voted on patch set 8 V +1 10/02/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31893

  21. Benjamin Franzke commented on patch set 8 10/02/22, 16:58

    Hey, why is a double-space added in all the ".. code-block:: yaml" instructions (before "code-block")? Is that a new rule? It seems all .rst files always used ".. code-block:: yaml"
  22. Chris Müller commented on patch set 8 10/02/22, 17:06

    Reply

    We agreed in the documentation team to use an indentation of 4 spaces in RSTs to simplify copy/paste of code snippets (so now also double-space between ".." and "code-block"). Now, Lina streamlined this in the changelog.
  23. Chris Müller voted on patch set 8 V +1 CR +1 10/02/22, 17:13

  24. Benjamin Franzke commented on patch set 8 10/02/22, 17:39

    Reply

    ok, thx. would have loved this to be mentioned in the commit message and even better to do that in a separate patch and roll that out to all changelog files (from older releases), as we often copy from older files, and would thus reintroduce the "old" syntax.
  1. Georg Ringer uploaded patch set 9 10/02/22, 17:45

  2. Georg Ringer voted on patch set 9 V +1 CR +1 10/02/22, 17:45

  3. core-ci voted on patch set 9 V +1 10/02/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31900

  4. Georg Ringer rebased onto patch set 10 10/02/22, 20:59

  5. core-ci voted on patch set 10 V +1 10/02/22, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31916

  6. Chris Müller voted on patch set 10 V +1 CR +1 10/03/22, 04:28

  7. Lina Wolf commented on patch set 10 10/03/22, 08:23

    Reply

    It is still allowed to use any kind of spacing from 2 to 4. And I guess it will be until we finally have figured out linting and automatic fixing. However upon touching the samples I unified them so it was easier to work on them. You can still copy from older samples and the documentation will be rendered without problem unless you mix different indentation styles in one section.
  8. Nikita Hovratov updated the commit message in patch set 11 10/03/22, 09:43

  9. Nikita Hovratov voted on patch set 11 V +1 CR +1 10/03/22, 09:44

  10. core-ci voted on patch set 11 V +1 10/03/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31932

  11. Annett Jähnichen wrote 10/03/22, 10:25

    Removed reviewer Annett Jähnichen.
  12. Lina Wolf rebased onto patch set 12 10/03/22, 11:38

  13. core-ci voted on patch set 12 V +1 10/03/22, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31937

  14. Lina Wolf uploaded patch set 13 10/03/22, 11:55

  15. core-ci voted on patch set 13 V +1 10/03/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31939

  16. Nikita Hovratov voted on patch set 13 V +1 CR +1 10/03/22, 12:18

  17. Chris Müller voted on patch set 13 V +1 CR +1 10/03/22, 15:06

  18. Nikita Hovratov uploaded patch set 14 10/03/22, 16:26

  19. Nikita Hovratov voted on patch set 14 V +1 CR +1 10/03/22, 16:26

  20. core-ci voted on patch set 14 V +1 10/03/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31948

  21. Chris Müller voted on patch set 14 V +1 CR +1 10/03/22, 16:48

  22. Georg Ringer voted on patch set 14 V +2 CR +2 10/03/22, 17:47

  23. Markus Klein commented on patch set 14 10/03/22, 18:19

    Breaking-94117-RegisterExtbaseTypeConvertersAsServices.rst:17

    I guess this was intended. The services.yaml file of each extension.
  24. Christian Kuhn commented on patch set 14 V +2 CR +2 10/03/22, 18:55

    Breaking-94117-RegisterExtbaseTypeConvertersAsServices.rst:17 Reply

    i don't see much of a difference and guess both is kinda fine. let's keep this to not loose votes again.
  25. Christian Kuhn merged patch set 15 10/03/22, 18:55