75939[!!!][TASK] Change method signatures and remove sanitization
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Kevin Appelt +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1316
-
Stefan Bürk uploaded patch set 1 10/02/22, 13:11
-
core-ci voted on patch set 1 V +1 10/02/22, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31873
-
Andreas Kienast voted on patch set 1 V +1 CR +1 10/02/22, 15:08
-
Oliver Klee commented on patch set 1 10/02/22, 16:09
-
Stefan Bürk commented on patch set 1 10/02/22, 16:14
ExpressionBuilder.php:616ReplyTYPO3 Fascade Connection has these PARAM_* to .. I and mabye others using a lot of Connection::PARAM_* constants ... which phpstan would than complain about. Would keep this as "int" . also it's not just this place. Maybe can be done afterwrads, globally as dedicated patch. As this is a breaking patch would be nice to have it merged before 12.0. -
Oliver Klee commented on patch set 1 10/02/22, 16:30
ExpressionBuilder.php:616ReplyIf both sets of constants are allowed (which is how I read your comment), we can use this to avoid these warnings while still providing the devs with help for spotting incorrect calls: @param \PDO::PARAM_*|Connection::PARAM_* -
Stefan Bürk uploaded patch set 2 10/02/22, 16:39
-
Stefan Bürk commented on patch set 2 10/02/22, 16:40
ExpressionBuilder.php:616Replydone. -
Stefan Bürk uploaded patch set 3 10/02/22, 16:42
-
core-ci voted on patch set 2 V +1 10/02/22, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31894
-
core-ci voted on patch set 3 V +1 10/02/22, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31895
-
Georg Ringer voted on patch set 3 CR +1 10/02/22, 17:48
-
Kevin Appelt voted on patch set 3 CR +1 10/02/22, 18:03
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/02/22, 20:29
-
Georg Ringer voted on patch set 3 V +2 CR +2 10/02/22, 20:58
-
Georg Ringer merged patch set 4 10/02/22, 20:58
ExpressionBuilder.php:616