75941[BUGFIX] Build LanguageService in TranslateViewHelper
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1317
-
Andreas Kienast uploaded patch set 1 10/02/22, 14:58
-
Andreas Kienast uploaded patch set 2 10/02/22, 14:59
-
Stefan Bürk commented on patch set 2 10/02/22, 15:02
-
Andreas Kienast commented on patch set 2 10/02/22, 15:04
TranslateViewHelper.php:225ReplyAck -
Andreas Kienast uploaded patch set 3 10/02/22, 15:04
-
core-ci voted on patch set 2 V +1 10/02/22, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31886
-
core-ci voted on patch set 3 V +1 10/02/22, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31887
-
core-ci voted on patch set 1 V +1 10/02/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31885
-
Chris Müller commented on patch set 3 10/02/22, 15:18
TranslateViewHelper.php:216Why setting $GLOBALS['LANG'] and not returning early? This also avoids the unsexy if-else construct. Also, setting the global variable in this context may have side effects?TranslateViewHelper.php:220Here too.TranslateViewHelper.php:222Here too. -
Andreas Kienast commented on patch set 3 10/02/22, 15:25
TranslateViewHelper.php:216ReplyIMO it's more "unappealing" to set GLOBALS/lang and return it directly again. The construction of LanguageService itself could be moved to a separate method, which solves the concern. I set GLOBALS/lang for performance reasons to avoid unnecessary reconstruction of the "same" LanguageService with every invocation of the view helper. -
Stefan Bürk uploaded patch set 4 10/02/22, 16:03
-
Chris Müller commented on patch set 4 10/02/22, 16:12
TranslateViewHelper.php:216ReplyAckTranslateViewHelper.php:220ReplyDoneTranslateViewHelper.php:222ReplyDone -
core-ci voted on patch set 4 V +1 10/02/22, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31890
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/02/22, 16:31
-
Georg Ringer voted on patch set 4 V +1 CR +1 10/02/22, 18:31
-
Georg Ringer voted on patch set 4 V +2 CR +2 10/02/22, 19:17
-
Georg Ringer merged patch set 5 10/02/22, 19:17
TranslateViewHelper.php:225