75944[!!!][TASK] Use new TypoScript parser in Frontend
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 29
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Event/AfterTemplatesHaveBeenDeterminedEvent.phpnew+55 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.php+12 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateRepository.phpnew+199 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeBuilder.php+29 −170
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+4 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php8+12 −79
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php4+13 −9
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −9
- typo3/sysext/core/Configuration/Services.yaml+8 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97816-NewTypoScriptParserInFrontend.rstnew+77 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97816-NewAfterTemplatesHaveBeenDeterminedEvent.rstnew+33 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateRepositoryTest.phpnew+95 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeBuilderTest.php+36 −9
- typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.php+0 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+419 −213
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+7 −19
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+5 −10
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+10 −0
Show 9 more files
- typo3/sysext/frontend/ext_localconf.php+13 −0
- typo3/sysext/install/Classes/Configuration/Cache/CustomCachePreset.php+0 −1
- typo3/sysext/install/Classes/Configuration/Cache/DatabaseCachePreset.php+0 −2
- typo3/sysext/install/Classes/Configuration/Cache/FileCachePreset.php+0 −2
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+8 −1
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+11 −2
- typo3/sysext/tstemplate/Classes/Controller/ObjectBrowserController.php+16 −5
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+10 −3
Review log 1520
-
Christian Kuhn uploaded patch set 1 10/03/22, 00:34
-
Christian Kuhn commented on patch set 1 CR -1 10/03/22, 00:44
needs commit message and .rst files. -
core-ci voted on patch set 1 V +1 10/03/22, 00:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31921
-
Stefan Bürk commented on patch set 1 10/03/22, 10:39
TemplateService.php:829Should this not be guarded by a is_string(), what do you think ? ``` if (is_string($setup) && $setup !== '') {} ```TemplateService.php:834same as above, is_string guard ?TemplateService.php:841same as above, is_string guard ?TemplateService.php:846same as above, is_string guard ?ExtensionManagementUtility.php:1170are we sure that this is set and it is a string ? or shoud we add a check and setting empty string if not ? ( ??= guard )ExtensionManagementUtility.php:1185see above: are we sure that this is set and it is a string ? or shoud we add a check and setting empty string if not ? ( ??= guard ) -
Christian Kuhn commented on patch set 1 10/03/22, 10:50
TemplateService.php:829ReplyDoneTemplateService.php:834ReplyDoneTemplateService.php:841ReplyDoneTemplateService.php:846ReplyDoneExtensionManagementUtility.php:1170ReplyDoneExtensionManagementUtility.php:1185ReplyDone -
Christian Kuhn uploaded patch set 2 10/03/22, 11:49
-
core-ci voted on patch set 2 V +1 10/03/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31938
-
Christian Kuhn voted on patch set 2 CR -1 10/03/22, 12:07
-
Christian Kuhn uploaded patch set 3 10/03/22, 12:25
-
core-ci voted on patch set 3 V +1 10/03/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31940
-
Christian Kuhn uploaded patch set 4 10/03/22, 13:35
-
core-ci voted on patch set 4 V +1 10/03/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31946
-
Stefan Bürk voted on patch set 4 CR +1 10/03/22, 16:27
-
Stefan Bürk commented on patch set 4 CR -1 10/03/22, 17:13
getting some "" invalid cache identifier exceptions on my installation ... -
Christian Kuhn uploaded patch set 5 10/03/22, 17:44
-
Stefan Bürk voted on patch set 5 V +1 CR +1 10/03/22, 17:52
-
core-ci voted on patch set 5 V +1 10/03/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31950
-
Benni Mack voted on patch set 5 V +1 CR +1 10/03/22, 17:58
-
Benni Mack voted on patch set 5 V +2 CR +2 10/03/22, 17:58
-
Benni Mack merged patch set 6 10/03/22, 17:58