Review main Merged

75945[TASK] Mitigate Browser "Spell-Jacking" in additional form elements

Oliver Hader CR +2 V +2 Easy +2 −1 updated 10/03/22, 09:58

Commit message

Disables spell checking in additional form elements:
* Setup Module `<form>` element
* ext:felogin `<form onsubmit>` element

See issue #98492 for details.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Kevin Appelt +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Kevin Appelt +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Oliver Hader uploaded patch set 1 10/03/22, 07:27

  2. Benjamin Franzke voted on patch set 1 V +1 CR +1 10/03/22, 07:30

  3. Torben Hansen voted on patch set 1 V +1 CR +1 10/03/22, 07:31

  4. Oliver Hader voted on patch set 1 CR -1 10/03/22, 07:34

  5. core-ci voted on patch set 1 V +1 10/03/22, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31927

  6. Oliver Hader uploaded patch set 2 10/03/22, 07:48

  7. Oliver Hader commented on patch set 2 10/03/22, 07:49

    I discovered another missing element... it's fine now
  8. core-ci voted on patch set 2 V +1 10/03/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31928

  9. Kevin Appelt commented on patch set 2 V +1 CR +1 10/03/22, 07:56

    .
  10. Torben Hansen voted on patch set 2 V +1 CR +1 10/03/22, 09:18

  11. Oliver Hader voted on patch set 2 V +2 CR +2 10/03/22, 09:58

  12. Oliver Hader merged patch set 3 10/03/22, 09:58