Review 11.5 Merged

75946[TASK] Mitigate browser "spell jacking" in form elements

Oliver Hader CR +2 V +2 Easy +21 −18 updated 10/04/22, 17:02

Commit message

Having manually(!) enabled "enhanced spell checking" in browsers,
can lead to scenarios where password data is sent to remote services
which actually take care of the spell checking.

see https://www.otto-js.com/news/article/chrome-and-edge-enhanced-spellcheck-features-expose-pii-even-your-passwords

Since this issue is caused by browsers and the determination of
"confidentiality" is fuzzy here, this issue is handled in public.

Following changes have been applied:
+ forms dealing mainly with credentials, as well as all forms in
  ext:install  have been adjusted to `<form ... spellcheck="false">`
+ other password form elements, including TCA type `password` have
  been adjusted to `<input type="password" ... spellcheck="false">`

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 16

Review log 45

  1. Oliver Hader uploaded patch set 1 10/03/22, 08:00

  2. core-ci voted on patch set 1 V +1 10/03/22, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31929

  3. Benni Mack voted on patch set 1 CR +1 10/04/22, 14:32

  4. Oliver Hader voted on patch set 1 V +2 CR +2 10/04/22, 17:02

  5. Oliver Hader merged patch set 2 10/04/22, 17:02