75950[!!!][TASK] Add strict types to GU::fixed_lgd_cs
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Kevin Appelt +1
- Markus Klein +1
-
Verified V +2 Done
- Stefan Bürk +2
- Markus Klein +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1216
-
Nikita Hovratov uploaded patch set 1 10/03/22, 13:10
-
Nikita Hovratov updated the commit message in patch set 2 10/03/22, 13:12
-
Markus Klein voted on patch set 2 V +1 CR +1 10/03/22, 13:21
-
core-ci voted on patch set 1 V -1 10/03/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31942
-
core-ci voted on patch set 2 V -1 10/03/22, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31943
-
Nikita Hovratov uploaded patch set 3 10/03/22, 13:30
-
Nikita Hovratov updated the commit message in patch set 4 10/03/22, 13:32
-
core-ci voted on patch set 4 V +1 10/03/22, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31945
-
core-ci voted on patch set 3 V +1 10/03/22, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31944
-
Kevin Appelt voted on patch set 4 CR +1 10/03/22, 14:29
-
Markus Klein voted on patch set 4 V +1 CR +1 10/03/22, 14:34
-
Stefan Bürk commented on patch set 4 CR -1 10/03/22, 16:55
As this is marked "breaking", following the rules it should have a breaking rst or amend to one. Maybe add it to the collection breaking rst regarding strict type, argumetn/return type rst file (started from Larry) ? -
Oliver Klee commented on patch set 4 CR +1 10/03/22, 17:03
Reply
We already have a breaking RST for GU getting marked as strict. We might need to check whether we need to adapt the RST for this change here. -
Stefan Bürk commented on patch set 4 V +2 CR +2 10/03/22, 17:05
Checked. Already "covered" in a collection rest file. -
Stefan Bürk commented on patch set 4 10/03/22, 17:06
Reply
Done -
Stefan Bürk merged patch set 5 10/03/22, 17:06