75951[TASK] Improve type annotations for ExpressionBuilder::literal()
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1214
-
Oliver Klee uploaded patch set 1 10/03/22, 16:27
-
core-ci voted on patch set 1 V +1 10/03/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31949
-
Stefan Bürk voted on patch set 1 V +1 CR +1 10/03/22, 16:52
-
Nikita Hovratov commented on patch set 1 10/03/22, 17:12
Does this also work for Connection::PARAM_INT_ARRAY ? -
Christian Kuhn commented on patch set 1 CR -1 10/03/22, 19:21
Reply
I think Nikita is correct: Connection adds PARAM_INT_ARRAY and a couple of others that don't exist in PDO. -
Stefan Bürk wrote 10/03/22, 19:23
Removed Code-Review+1 by Stefan Bürk -
Stefan Bürk wrote 10/03/22, 19:23
Removed Verified+1 by Stefan Bürk -
Oliver Klee commented on patch set 1 CR -1 10/03/22, 21:06
Going to check this. -
Oliver Klee uploaded patch set 2 10/19/22, 11:32
-
Oliver Klee commented on patch set 2 10/19/22, 11:32
Reply
Done -
core-ci voted on patch set 2 V +1 10/19/22, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32464
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 10/19/22, 11:53
-
Stefan Bürk voted on patch set 2 V +2 CR +2 10/19/22, 11:58
-
Stefan Bürk merged patch set 3 10/19/22, 11:58