75975[FEATURE] Username in password recovery mail
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Guido Schmechel +1
-
Verified V +2 Done
- Benni Mack +2
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+2 −0
- typo3/sysext/backend/Resources/Private/Templates/Email/PasswordReset/ResetRequested.html2+1 −0
- typo3/sysext/backend/Resources/Private/Templates/Email/PasswordReset/ResetRequested.txt+1 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-98517-UsernameInBackendPasswordResetMail.rst2new+40 −0
Review log 2738
Show 813 earlier messages
-
Mario Lubenka uploaded patch set 1 10/04/22, 10:17
-
core-ci voted on patch set 1 V +1 10/04/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31973
-
Chris Müller commented on patch set 1 10/04/22, 11:44
-
Mario Lubenka rebased onto patch set 2 10/04/22, 14:41
-
core-ci voted on patch set 2 V -1 10/04/22, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31986
-
Mario Lubenka rebased onto patch set 3 10/05/22, 06:24
-
Mario Lubenka rebased onto patch set 4 10/05/22, 06:33
-
core-ci voted on patch set 3 V +1 10/05/22, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32022
-
core-ci voted on patch set 4 V +1 10/05/22, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32026
-
Mario Lubenka uploaded patch set 5 10/06/22, 07:08
-
Mario Lubenka commented on patch set 5 10/06/22, 07:09
Feature-98517-UsernameInBackendPasswordResetMail.rst:35ReplyThanks. I was looking for something like that but did not find it :) -
core-ci voted on patch set 5 V +1 10/06/22, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32052
-
Frank Nägler commented on patch set 5 CR -1 10/07/22, 17:26
@Oliver @Torben: What do you think about this feature from security point of view? Yes, it must be enabled, but I have a bad feeling with this change. -1 until we get a feedback from the security team.
-
Oliver Hader commented on patch set 5 10/21/22, 07:26
Reply
I don't see a problem here. There are scenarios where an email address is already used as username. @Frank: What are your concerns or bad feelings about? -
Anja Leichsenring uploaded patch set 6 10/21/22, 07:40
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 10/21/22, 07:41
-
core-ci voted on patch set 6 V +1 10/21/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32561
-
Oliver Hader commented on patch set 6 10/21/22, 07:56
I think the additional setting `passwordResetDisplayUserName` to enable this feature can be omitted, couldn't it?ResetRequested.html:7Results in `Your username is: jane.doe.` - probably remove the dot again... or put things in quotes... -
Oliver Hader voted on patch set 6 CR -1 10/21/22, 07:56
-
Mario Lubenka commented on patch set 6 10/27/22, 11:42
Reply
If that feature is not a security issue, we can enable it by default. At least for websites that do not use email address as username I think it's a minor security aspect, as a bad guy that has access to the mailbox can reset the password, but does not know the username for login until this change. -
Mario Lubenka uploaded patch set 7
CR +1V +102/08/23, 13:00 -
Mario Lubenka commented on patch set 7 02/08/23, 13:00
Reply
Setting removed. -
Mario Lubenka uploaded patch set 8 02/08/23, 13:04
-
Mario Lubenka commented on patch set 7 02/08/23, 13:04
ResetRequested.html:7ReplyDone -
core-ci voted on patch set 7 V -1 02/08/23, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37359
-
Mario Lubenka uploaded patch set 9 02/08/23, 13:11
-
core-ci voted on patch set 8 V -1 02/08/23, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37360
-
core-ci voted on patch set 9 V +1 02/08/23, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37362
-
Benni Mack rebased onto patch set 10
V +103/23/23, 10:21 -
core-ci voted on patch set 10 V +1 03/23/23, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39454
-
Guido Schmechel voted on patch set 10 V +1 CR +1 03/23/23, 20:45
-
Torben Hansen commented on patch set 10 03/24/23, 07:28
Feature-98517-UsernameInBackendPasswordResetMail.rst:25Since the feature is always enabled (no setting to adjust it), the word "Enabling" can be removed. -
Benni Mack commented on patch set 11
CR +1V +103/24/23, 08:19Published edit on patch set 10. -
Benni Mack commented on patch set 11 V +1 CR +1 03/24/23, 08:19
Feature-98517-UsernameInBackendPasswordResetMail.rst:25ReplyDone -
core-ci voted on patch set 11 V +1 03/24/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39523
-
Guido Schmechel voted on patch set 11 V +1 CR +1 03/24/23, 09:25
-
Benni Mack voted on patch set 11 V +2 CR +2 03/24/23, 09:35
-
Benni Mack merged patch set 12 03/24/23, 09:38
Feature-98517-UsernameInBackendPasswordResetMail.rst:35