Review main Merged

75979[TASK] Raise friendsofphp/php-cs-fixer:^3.11.0

Christian Kuhn CR +2 V +2 Hard +43 −249 updated 10/04/22, 14:55

Commit message

This avoids abandoned php-cs-fixer/diff. The raise
brings a series of CGL changes.

> composer req --dev friendsofphp/php-cs-fixer:^3.11.0
> Build/Scripts/runTests.sh -s cgl -p 8.1

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Kevin Appelt +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Kevin Appelt +1
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 169

Show 149 more files

Review log 78

  1. Christian Kuhn uploaded patch set 1 10/04/22, 14:23

  2. Benni Mack commented on patch set 1 10/04/22, 14:24

    YES!
  3. core-ci voted on patch set 1 V +1 10/04/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31980

  4. Christian Kuhn commented on patch set 1 10/04/22, 14:34

    i tend to merge this relatively quickly, nightly should stay happy, too.
  5. Simon Gilli commented on patch set 1 V +1 CR +1 10/04/22, 14:50

    Looks good!
  6. Kevin Appelt commented on patch set 1 V +1 CR +1 10/04/22, 14:53

    +0 -1 => remove blank line +0 -2 => remove 2 blank lines +2 -2 => change indentation in “empty” switch default +1 -1 => removed comma in inline array with no value after the comma Should be fine :)
  7. Christian Kuhn commented on patch set 1 V +2 CR +2 10/04/22, 14:55

    thx 4 quick reviews!
  8. Christian Kuhn merged patch set 2 10/04/22, 14:55