75979[TASK] Raise friendsofphp/php-cs-fixer:^3.11.0
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Kevin Appelt +1
- Simon Gilli +1
-
Verified V +2 Done
- Christian Kuhn +2
- Kevin Appelt +1
- Simon Gilli +1
- core-ci +1 CI
Issues 1
Files 169
- Build/php-cs-fixer.php+1 −1
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelRenderer.php+0 −1
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php+0 −1
- typo3/sysext/adminpanel/Classes/ModuleApi/DataProviderInterface.php+0 −1
- typo3/sysext/adminpanel/Classes/Service/ModuleLoader.php+0 −1
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php+0 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php+0 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −2
- typo3/sysext/backend/Classes/LinkHandler/FileLinkHandler.php+0 −1
- typo3/sysext/backend/Classes/Preview/StandardPreviewRendererResolver.php+0 −1
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+0 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+0 −2
- typo3/sysext/backend/Classes/View/BackendLayout/DefaultDataProvider.php+0 −1
- typo3/sysext/backend/Classes/View/ProgressListenerInterface.php+0 −1
- typo3/sysext/backend/Tests/Unit/Controller/SiteConfigurationControllerTest.php+0 −1
Show 149 more files
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php+0 −1
- typo3/sysext/core/Classes/Cache/DatabaseSchemaService.php+0 −1
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php+2 −2
- typo3/sysext/core/Classes/Context/TypoScriptAspect.php+0 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/Lexer.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+2 −2
- typo3/sysext/core/Classes/DataHandling/PagePermissionAssembler.php+0 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+0 −1
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+4 −4
- typo3/sysext/core/Classes/Http/Message.php+0 −1
- typo3/sysext/core/Classes/LinkHandling/EmailLinkHandler.php+0 −1
- typo3/sysext/core/Classes/LinkHandling/FolderLinkHandler.php+0 −1
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+0 −1
- typo3/sysext/core/Classes/LinkHandling/PageLinkHandler.php+0 −1
- typo3/sysext/core/Classes/LinkHandling/TelephoneLinkHandler.php+0 −1
- typo3/sysext/core/Classes/LinkHandling/UrlLinkHandler.php+0 −1
- typo3/sysext/core/Classes/Localization/Locales.php+1 −1
- typo3/sysext/core/Classes/Preparations/TcaPreparation.php+0 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+0 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+0 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/IpAnonymizationUtility.php+0 −1
- typo3/sysext/core/Tests/Functional/RegistryTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/PagePermissionRestrictionTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypeAttributes/CharacterTypeAttributesTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypeAttributes/EnumerationTypeAttributesTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypeAttributes/NumericTypeAttributesTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+0 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/EmailLinkHandlerTest.php+0 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/PageLinkHandlerTest.php+0 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/TelephoneLinkHandlerTest.php+0 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/UrlLinkHandlerTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageRendererResolverTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Utility/ClassNamingUtilityTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Utility/IpAnonymizationUtilityTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Utility/VersionNumberUtilityTest.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+0 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DependencyTest.php+0 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php+0 −1
- typo3/sysext/felogin/Configuration/TCA/Overrides/fe_groups.php+0 −1
- typo3/sysext/felogin/Configuration/TCA/Overrides/fe_users.php+0 −1
- typo3/sysext/form/Classes/Domain/Condition/Functions/FormConditionFunctionsProvider.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/ArrayProcessing/ArrayProcessing.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/ArrayProcessing/ArrayProcessor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FlexformConfiguration/Processors/ProcessorInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/AbstractConverter.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/AddHmacDataConverter.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/AddHmacDataToFormElementPropertyConverter.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/AddHmacDataToPropertyCollectionElementConverter.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/ConverterDto.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/ConverterInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/FinisherTranslationLanguageConverter.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/RemoveHmacDataConverter.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CollectionBasedValidator.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidator.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidator.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/ElementBasedValidator.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/FormElementHmacDataValidator.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/PropertyCollectionElementHmacDataValidator.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/ValidationDto.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/ValidatorInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/IsCreatableFormElementExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/MultiValuePropertiesExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/PredefinedDefaultsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/PropertyPathsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/FormElement/SelectOptionsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/IsCreatablePropertyCollectionElementExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/MultiValuePropertiesExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/PredefinedDefaultsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/PropertyPathsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/PropertyCollectionElement/SelectOptionsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/AbstractExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/AdditionalElementPropertyPathsExtractor.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/ExtractorDto.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/ExtractorInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+0 −1
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+0 −1
- typo3/sysext/form/Classes/Domain/Factory/FormFactoryInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/ClosureFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/DeleteUploadsFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/FinisherVariableProvider.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/FlashMessageFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Date.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/DatePicker.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FormElementInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Page.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractCompositeRenderable.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/CompositeRenderableInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableVariant.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableVariantInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/RootRenderableInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/VariableRenderableInterface.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+0 −1
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+0 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormState.php+0 −1
- typo3/sysext/form/Classes/Hooks/FormElementHooks.php+0 −1
- typo3/sysext/form/Classes/Hooks/ImportExportHook.php+0 −1
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+0 −1
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php+0 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+0 −1
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+0 −1
- typo3/sysext/form/Classes/Service/DatabaseService.php+0 −1
- typo3/sysext/form/Classes/Service/TranslationService.php+0 −1
- typo3/sysext/form/Tests/Functional/Framework/FormHandling/FormDataFactory.php+1 −1
- typo3/sysext/form/Tests/Unit/Controller/AbstractBackendControllerTest.php+0 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidatorTest.php+0 −1
- typo3/sysext/form/Tests/Unit/Domain/Renderable/AbstractRenderableTest.php+0 −1
- typo3/sysext/frontend/Classes/Aspect/PreviewAspect.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+0 −1
- typo3/sysext/frontend/Classes/DataProcessing/FlexFormProcessor.php+0 −1
- typo3/sysext/frontend/Classes/DataProcessing/GalleryProcessor.php+0 −1
- typo3/sysext/frontend/Classes/DataProcessing/SiteProcessor.php+0 −1
- typo3/sysext/frontend/Classes/Middleware/ContentLengthResponseHeader.php+0 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/DataProcessing/SiteProcessorTest.php+0 −1
- typo3/sysext/indexed_search/Classes/FileContentParser.php+3 −3
- typo3/sysext/indexed_search/Classes/Indexer.php+0 −1
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+2 −2
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+0 −1
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −1
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+2 −2
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php+0 −1
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/Sqlite.php+0 −1
- typo3/sysext/redirects/Classes/Service/RedirectService.php+2 −2
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+0 −1
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationTask.php+0 −1
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+0 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+0 −2
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+2 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −2
- composer.json+1 −1
- composer.lock+8 −61
Review log 78
-
Christian Kuhn uploaded patch set 1 10/04/22, 14:23
-
Benni Mack commented on patch set 1 10/04/22, 14:24
YES! -
core-ci voted on patch set 1 V +1 10/04/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31980
-
Christian Kuhn commented on patch set 1 10/04/22, 14:34
i tend to merge this relatively quickly, nightly should stay happy, too. -
Simon Gilli commented on patch set 1 V +1 CR +1 10/04/22, 14:50
Looks good! -
Kevin Appelt commented on patch set 1 V +1 CR +1 10/04/22, 14:53
+0 -1 => remove blank line +0 -2 => remove 2 blank lines +2 -2 => change indentation in “empty” switch default +1 -1 => removed comma in inline array with no value after the comma Should be fine :) -
Christian Kuhn commented on patch set 1 V +2 CR +2 10/04/22, 14:55
thx 4 quick reviews! -
Christian Kuhn merged patch set 2 10/04/22, 14:55