Review main Merged

75981[BUGFIX] Uninitialized properties in DebuggerUtility

Mario Lubenka CR +2 V +2 Easy +24 −2 updated 10/10/22, 12:54

Commit message

DebuggerUtility::var_dump() is commonly used to debug PHP classes.

We recommend hardening PHP classes by using typed properties in PHP
classes. Previously uninitialized properties resulted in a PHP exception
when passing the class instance into DebuggerUtility::var_dump.

Uninitialized properties will not be processed by
DebuggerUtility::var_dump anymore. Instead a label "uninitialized"
indicates that it has not been initialized at the time of debugging.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Mario Lubenka uploaded patch set 1 10/04/22, 14:38

  2. Mario Lubenka rebased onto patch set 2 10/04/22, 14:41

  3. core-ci voted on patch set 1 V -1 10/04/22, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31984

  4. core-ci voted on patch set 2 V -1 10/04/22, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31985

  5. Georg Ringer commented on patch set 2 10/04/22, 19:33

    IMO no feature but a regular bugfix and should go into 11 as well
  6. Mario Lubenka uploaded patch set 3 10/05/22, 06:24

  7. Mario Lubenka rebased onto patch set 4 10/05/22, 06:27

  8. Mario Lubenka commented on patch set 4 10/05/22, 06:39

    Reply

    Fine by me. What do I do with the Changelog file? Going into 11.5 as well, it should not be part of this change. Completely remove it, or open another change that goes into 11.5?
  9. core-ci voted on patch set 4 V +1 10/05/22, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32024

  10. core-ci voted on patch set 3 V +1 10/05/22, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32023

  11. Georg Ringer commented on patch set 4 10/06/22, 19:40

    no rst needed at all
  12. Christian Kuhn uploaded patch set 5 10/10/22, 12:43

  13. Christian Kuhn commented on patch set 5 V +1 CR +1 10/10/22, 12:44

    nice one, thx! i agree a .rst isn't needed here and removed it. patch looks good to me.
  14. Christian Kuhn commented on patch set 5 10/10/22, 12:45

    Reply

    Done
  15. core-ci voted on patch set 5 V +1 10/10/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32139

  16. Stefan Bürk voted on patch set 5 V +2 CR +2 10/10/22, 12:54

  17. Stefan Bürk merged patch set 6 10/10/22, 12:54