Review main Merged

75982[FEATURE] Introduce PSR-14 event to modify form data for edit file form

Oli Bartsch CR +2 V +2 Hard +271 −7 updated 10/04/22, 19:43

Commit message

This introduces a new PSR-14 event, enabling
extension authors to modify the form data, used
by FormEngine to generate the edit file form in
the filelist module.

TYPO3 internally makes use of this event to
initialize t3editor with the suitable format options
for the file to be edited. This functionality was
previously done in a hook (#98494), which
however did no longer work due to the removal
of said hook in #97452.

Effectively this means, the new Event is an
improved replacement for the removed hook,
since the Event now provides the whole form
data array as well as the resolved FileInterface
and the current PSR-7 Request.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 912

  1. Oli Bartsch uploaded patch set 1 10/04/22, 14:49

  2. Oli Bartsch uploaded patch set 2 10/04/22, 14:57

  3. core-ci voted on patch set 1 V -1 10/04/22, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31988

  4. Oli Bartsch uploaded patch set 3 10/04/22, 15:12

  5. core-ci voted on patch set 2 V -1 10/04/22, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31989

  6. core-ci voted on patch set 3 V +1 10/04/22, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31991

  7. Stefan Bürk voted on patch set 3 CR +1 10/04/22, 18:19

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 10/04/22, 19:04

  9. Stefan Bürk voted on patch set 3 V +2 CR +2 10/04/22, 19:05

  10. Stefan Bürk merged patch set 4 10/04/22, 19:05

  11. Georg Ringer voted on patch set 3 V +1 CR +1 10/04/22, 19:05

  12. Benni Mack voted on patch set 4 CR +1 10/04/22, 19:43