Review main Merged

75983[TASK] Update to PHPStan 1.8.7

Oliver Klee CR +2 V +2 Normal +201 −44 updated 10/04/22, 18:08

Commit message

This update finds new problems and gets rid of some
false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.7
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 47

  1. Oliver Klee uploaded patch set 1 10/04/22, 15:05

  2. core-ci voted on patch set 1 V +1 10/04/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31990

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/04/22, 16:24

  4. core-ci voted on patch set 1 V -1 10/04/22, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32002

  5. core-ci voted on patch set 1 V +1 10/04/22, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32002

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 10/04/22, 18:08

  7. Stefan Bürk merged patch set 2 10/04/22, 18:08