Review main Merged

75984[TASK] Tune php-cs-fixer setup

Christian Kuhn CR +2 V +2 Easy +21 −23 updated 10/04/22, 17:51

Commit message

Some minor php-cs-fixer modifications:
* Move main config file to Build/php-cs-fixer
* Adapt runTests.sh setup and helper scripts
* Check Build/ directory, too
* Simplify config a bit

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 813

  1. Christian Kuhn uploaded patch set 1 10/04/22, 15:23

  2. Benni Mack voted on patch set 1 CR +1 10/04/22, 15:27

  3. Oliver Klee voted on patch set 1 CR +1 10/04/22, 15:31

  4. core-ci voted on patch set 1 V +1 10/04/22, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31992

  5. core-ci voted on patch set 1 V -1 10/04/22, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31993

  6. Christian Kuhn uploaded patch set 2 10/04/22, 16:39

  7. Christian Kuhn uploaded patch set 3 10/04/22, 16:39

  8. Christian Kuhn commented on patch set 3 10/04/22, 16:42

    sorry, had to fiddle a bit more due to symfony/finder shenanigans ...
  9. core-ci voted on patch set 3 V -1 10/04/22, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31999

  10. core-ci voted on patch set 3 V +1 10/04/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31998

  11. core-ci commented on patch set 3 10/04/22, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31999

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 10/04/22, 17:51

  13. Christian Kuhn merged patch set 4 10/04/22, 17:51