Review 11.5 Merged

75985[TASK] Update to PHPStan 1.8.7

Christian Kuhn CR +2 V +2 Hard +212 −62 updated 10/04/22, 18:08

Commit message

This update finds new problems and gets rid of some
false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.7
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Christian Kuhn uploaded patch set 1 10/04/22, 15:32

  2. Oliver Klee voted on patch set 1 V +1 CR +1 10/04/22, 15:50

  3. core-ci voted on patch set 1 V +1 10/04/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31994

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 10/04/22, 16:24

  5. Stefan Bürk uploaded patch set 2 10/04/22, 16:32

  6. Christian Kuhn uploaded patch set 3 10/04/22, 16:52

  7. Oliver Klee voted on patch set 3 CR +1 10/04/22, 16:57

  8. core-ci voted on patch set 2 V -1 10/04/22, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31996

  9. core-ci voted on patch set 3 V +1 10/04/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32001

  10. Oliver Klee voted on patch set 3 V +1 10/04/22, 18:03

  11. core-ci commented on patch set 3 10/04/22, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32003

  12. Stefan Bürk voted on patch set 3 V +2 CR +2 10/04/22, 18:08

  13. Stefan Bürk merged patch set 4 10/04/22, 18:08