Review main Merged

75988[BUGFIX] Remove obsolete VH usage from site template

Christian Kuhn CR +2 V +2 Easy +0 −3 updated 10/04/22, 18:30

Commit message

Using <em:be.trigger triggers="{triggers}" /> in the
template seems to be obsolete since the controller
never sets the triggers variable.

This avoids a nasty cross-dependency from ext:backend
to ext:extensionmanager.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/04/22, 18:11

  2. Georg Ringer voted on patch set 1 V +1 CR +1 10/04/22, 18:20

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/04/22, 18:24

  4. core-ci voted on patch set 1 V +1 10/04/22, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32005

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 10/04/22, 18:30

  6. Stefan Bürk merged patch set 2 10/04/22, 18:30