Review main Merged

75991[BUGFIX] Determine MariaDB Server Version correctly when prefixed

Stefan Bürk CR +2 V +2 Normal +127 −4 updated 10/15/22, 11:49

Commit message

Some builds of MariaDB server and/or report server version of
MariaDB with a '5.5.5-' prefix. This change address changes
a regex to deal with this detail in the environment check

Prefixed server version information looks like:

  "MySQL 5.5.5-10.3.32-MariaDB-1:10.3.32+maria~focal-log"

compared to other MySQL servers, which don't add the '5.5.5-' prefix.

Invalid version detection will now display a dedicated message to
express that transparently.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1725

  1. Stefan Bürk uploaded patch set 1 10/04/22, 20:51

  2. core-ci voted on patch set 1 V +1 10/04/22, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32014

  3. Simon Schaufelberger commented on patch set 1 10/04/22, 23:24

    MySql.php:147

    dots should be escaped, or?
  4. Stefan Bürk uploaded patch set 2 10/05/22, 06:33

  5. Stefan Bürk commented on patch set 2 10/05/22, 06:36

    MySql.php:147 Reply

    Ack. Done.
  6. core-ci voted on patch set 2 V +1 10/05/22, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32027

  7. Stefan Froemken commented on patch set 2 V +1 CR +1 10/05/22, 07:30

    I have left some links about that problem in the related forge ticket
  8. Christian Kuhn updated the commit message in patch set 3 10/05/22, 09:11

  9. Stefan Bürk commented on patch set 3 CR -1 10/05/22, 09:12

    will try to add a test for it
  10. core-ci voted on patch set 3 V +1 10/05/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32032

  11. Stefan Bürk uploaded patch set 4 10/13/22, 05:10

  12. Stefan Bürk commented on patch set 4 10/13/22, 05:10

    Reply

    Added tests to cover this.
  13. Stefan Bürk uploaded patch set 5 10/13/22, 05:12

  14. Stefan Bürk uploaded patch set 6 10/13/22, 05:15

  15. core-ci voted on patch set 4 V -1 10/13/22, 05:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32269

  16. core-ci voted on patch set 5 V -1 10/13/22, 05:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32270

  17. core-ci voted on patch set 6 V +1 10/13/22, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32271

  18. Stefan Bürk uploaded patch set 7 10/13/22, 05:44

  19. core-ci voted on patch set 7 V +1 10/13/22, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32272

  20. Stefan Bürk rebased onto patch set 8 10/14/22, 09:33

  21. core-ci voted on patch set 8 V +1 10/14/22, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32319

  22. Christian Kuhn voted on patch set 8 V +1 CR +1 10/14/22, 22:04

  23. Stefan Froemken commented on patch set 8 V +1 CR +1 10/15/22, 08:24

    Pretty nice test ;-) I like the approach to make a method public. Link added to my favs.
  24. Stefan Bürk voted on patch set 8 V +2 CR +2 10/15/22, 11:48

  25. Stefan Bürk merged patch set 9 10/15/22, 11:49