Review main Merged

75995[TASK] Remove runThroughTemplatesPostProcessing hook

Christian Kuhn CR +2 V +2 Normal +62 −136 updated 10/07/22, 21:04

Commit message

Hook call runThroughTemplatesPostProcessing related to the
old TypoScript parser is now removed in the new TypoScript
parser: This hook has been marked as breaking in 12.0
already and was only kept for b/w compat in
typo3/testing-framework, which has been adapted meanwhile.

The substitution event AfterTemplatesHaveBeenDeterminedEvent
is slightly changed to provide the full Request to listeners
instead of just the Site object.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 19

Review log 1119

  1. Christian Kuhn uploaded patch set 1 10/05/22, 11:24

  2. Christian Kuhn uploaded patch set 2 10/05/22, 11:25

  3. core-ci voted on patch set 2 V -1 10/05/22, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32035

  4. core-ci voted on patch set 1 V -1 10/05/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32034

  5. Christian Kuhn uploaded patch set 3 10/05/22, 11:43

  6. core-ci voted on patch set 3 V +1 10/05/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32036

  7. Christian Kuhn uploaded patch set 4 10/07/22, 17:40

  8. core-ci voted on patch set 4 V +1 10/07/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32081

  9. Christian Kuhn uploaded patch set 5 10/07/22, 20:06

  10. core-ci voted on patch set 5 V -1 10/07/22, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32085

  11. Christian Kuhn updated the commit message in patch set 6 10/07/22, 20:40

  12. Christian Kuhn uploaded patch set 7 10/07/22, 20:43

  13. Christian Kuhn uploaded patch set 8 10/07/22, 20:46

  14. core-ci voted on patch set 6 V -1 10/07/22, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32087

  15. core-ci voted on patch set 8 V +1 10/07/22, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32089

  16. Stefan Bürk voted on patch set 8 V +1 CR +1 10/07/22, 20:58

  17. core-ci voted on patch set 7 V -1 10/07/22, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32088

  18. Christian Kuhn commented on patch set 8 V +2 CR +2 10/07/22, 21:04

    I hope it's ok to take the freedom to merge this: nightly will go red otherwise.
  19. Christian Kuhn merged patch set 9 10/07/22, 21:04