Review main Merged

75996[BUGFIX] Prevent undefined array index "pi_flexform"

Simon Schaufelberger CR +2 V +2 Easy +4 −3 updated 10/11/22, 04:16

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1518

  1. Simon Schaufelberger uploaded patch set 1 10/05/22, 13:44

  2. core-ci voted on patch set 1 V +1 10/05/22, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32039

  3. Oliver Klee commented on patch set 1 10/05/22, 14:21

    AbstractPlugin.php:1307

    I propose we introduce a local variable for $this->cObj->data[$field] to avoid 2 of the 3 read accesses and make the code more clear.
  4. Simon Schaufelberger uploaded patch set 2 10/05/22, 14:42

  5. Simon Schaufelberger commented on patch set 2 10/05/22, 14:43

    AbstractPlugin.php:1307 Reply

    like this?
  6. core-ci voted on patch set 2 V +1 10/05/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32043

  7. Oliver Klee commented on patch set 2 CR +1 10/05/22, 14:51

    AbstractPlugin.php:1307 Reply

    Yes, exactly. Beautiful!
  8. Simon Schaufelberger commented on patch set 2 10/05/22, 15:10

    AbstractPlugin.php:1307 Reply

    Done
  9. Oliver Klee commented on patch set 2 CR 0 10/05/22, 19:29

    AbstractPlugin.php:1308

    I've just noticed: We also need to cast $fieldData to a string for the xml2array call.
  10. Simon Schaufelberger commented on patch set 2 10/06/22, 00:21

    AbstractPlugin.php:1308 Reply

    shouldn't this be always a string? well, I will do that later.
  11. Simon Schaufelberger uploaded patch set 3 10/06/22, 08:51

  12. Simon Schaufelberger commented on patch set 3 10/06/22, 08:51

    AbstractPlugin.php:1308 Reply

    Done
  13. core-ci voted on patch set 3 V +1 10/06/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32055

  14. Oliver Klee voted on patch set 3 CR +1 10/06/22, 09:20

  15. Christian Kuhn voted on patch set 3 V +1 CR +1 10/10/22, 22:29

  16. Josef Glatz commented on patch set 3 V +1 CR +1 10/11/22, 03:53

    great, thx for the patch. had also such scenario
  17. Christian Kuhn voted on patch set 3 V +2 CR +2 10/11/22, 04:16

  18. Christian Kuhn merged patch set 4 10/11/22, 04:16