76005[BUGFIX] Avoid undefined array key access in TextMenuContentObject
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1417
-
Stefan Bürk uploaded patch set 1 10/08/22, 00:38
-
core-ci voted on patch set 1 V +1 10/08/22, 00:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32091
-
Oliver Klee commented on patch set 1 10/08/22, 07:49
-
Stefan Bürk commented on patch set 1 10/08/22, 10:56
TextMenuContentObject.php:92ReplyTime for a "??:" operator. "if null or falsable then..." Will change it. -
Oliver Klee commented on patch set 1 10/08/22, 11:32
TextMenuContentObject.php:92ReplyOther thoughts on this: - We probably want to throw in a string cast for good measure to avoid type warnings for the explode call if the TypoScript has bugs in it. - Instead of checking for truthyness/falsyness, we probably want to check for an empty string, which is semantically more correct. -
Stefan Bürk uploaded patch set 2 10/08/22, 12:12
-
Oliver Klee commented on patch set 2 10/08/22, 12:14
TextMenuContentObject.php:92ReplyOn it. -
Oliver Klee commented on patch set 3 10/08/22, 12:16
Published edit on patch set 2. -
Oliver Klee commented on patch set 3 10/08/22, 12:16
TextMenuContentObject.php:92ReplyDone -
core-ci voted on patch set 2 V +1 10/08/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32099
-
Stefan Bürk commented on patch set 3 10/08/22, 12:20
Thanks Oliver. Changes are fine for me. -
core-ci voted on patch set 3 V +1 10/08/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32100
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/08/22, 12:36
-
Oliver Klee voted on patch set 3 CR +1 10/08/22, 12:40
-
Andreas Kienast voted on patch set 3 V +1 CR +1 10/10/22, 12:50
-
Stefan Bürk voted on patch set 3 V +2 CR +2 10/10/22, 13:24
-
Stefan Bürk merged patch set 4 10/10/22, 13:24
TextMenuContentObject.php:92