Review main Merged

76007[TASK] Ensure unit tests properly call `parent::setUp()`

Stefan Bürk CR +2 V +2 Easy +29 −0 updated 10/08/22, 17:16

Commit message

This change ensures that unit tests has a valid `setUp()`
parent call chain down to the testing-framework base
class and acts as a pre-patch to introduce tightend
safe-guard checks on testing-framework level afterwards.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 68

  1. Stefan Bürk uploaded patch set 1 10/08/22, 16:58

  2. core-ci voted on patch set 1 V +1 10/08/22, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32104

  3. Stefan Bürk updated the commit message in patch set 2 10/08/22, 17:06

  4. Oliver Klee voted on patch set 2 V +1 CR +1 10/08/22, 17:07

  5. core-ci voted on patch set 2 V +1 10/08/22, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32105

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/08/22, 17:15

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 10/08/22, 17:16

  8. Stefan Bürk merged patch set 3 10/08/22, 17:16