Review main Merged

76010[TASK] Raise typo3/testing-framework to tighten tests

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 10/10/22, 17:02

Commit message

This change raises typo3/testing-framework to include a
bunch of changes to tighten unit- and function tests.

* setUp() call chain integrity check for unit-tests
* error_reporting() left-over integrity check for
  unit- and functional tests
* error- and exception handler left-over integrity
  check for unit- and function tests (unit is new)

Used command(s):

> composer update typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Stefan Bürk uploaded patch set 1 10/08/22, 18:57

  2. core-ci voted on patch set 1 V -1 10/08/22, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32108

  3. Stefan Bürk commented on patch set 1 10/08/22, 19:06

    Failing was expetect. Needs this one merged first: 76009: [BUGFIX] Properly cleanup registered exception handlers in tests | https://review.typo3.org/c/Packages/TYPO3.CMS/+/76009 After that and a rebase tests should be become green.
  4. Stefan Bürk rebased onto patch set 2 10/09/22, 12:12

  5. core-ci voted on patch set 2 V +1 10/09/22, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32122

  6. Stefan Bürk uploaded patch set 3 10/10/22, 16:38

  7. core-ci voted on patch set 3 V +1 10/10/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32153

  8. Stefan Bürk updated the commit message in patch set 4 10/10/22, 16:47

  9. core-ci voted on patch set 4 V +1 10/10/22, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32154

  10. Jochen Roth voted on patch set 4 V +1 CR +1 10/10/22, 17:01

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 10/10/22, 17:02

  12. Christian Kuhn merged patch set 5 10/10/22, 17:02