Review main Merged

76032[TASK] Replace prophecy calls in AdminPanelInitiatorTest

Anja Leichsenring CR +2 V +2 Normal +24 −41 updated 10/09/22, 17:38

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Anja Leichsenring uploaded patch set 1 10/09/22, 10:03

  2. core-ci voted on patch set 1 V -1 10/09/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32118

  3. Anja Leichsenring uploaded patch set 2 10/09/22, 11:58

  4. core-ci voted on patch set 2 V +1 10/09/22, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32120

  5. Stefan Bürk commented on patch set 2 CR -1 10/09/22, 12:31

    on it ...
  6. Stefan Bürk uploaded patch set 3 10/09/22, 12:37

  7. core-ci voted on patch set 3 V +1 10/09/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32123

  8. Stefan Bürk commented on patch set 3 V +1 CR +1 10/09/22, 13:02

    We should avoid to simply add phpstan baseline ignores on new code. Changed the change to avoid the need for it, using a proper docblock comment to solve this. Hope the change is fine for you Anja.
  9. Oliver Klee voted on patch set 3 V +1 CR +1 10/09/22, 16:29

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 10/09/22, 17:38

  11. Stefan Bürk merged patch set 4 10/09/22, 17:38