76032[TASK] Replace prophecy calls in AdminPanelInitiatorTest
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 811
-
Anja Leichsenring uploaded patch set 1 10/09/22, 10:03
-
core-ci voted on patch set 1 V -1 10/09/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32118
-
Anja Leichsenring uploaded patch set 2 10/09/22, 11:58
-
core-ci voted on patch set 2 V +1 10/09/22, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32120
-
Stefan Bürk commented on patch set 2 CR -1 10/09/22, 12:31
on it ... -
Stefan Bürk uploaded patch set 3 10/09/22, 12:37
-
core-ci voted on patch set 3 V +1 10/09/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32123
-
Stefan Bürk commented on patch set 3 V +1 CR +1 10/09/22, 13:02
We should avoid to simply add phpstan baseline ignores on new code. Changed the change to avoid the need for it, using a proper docblock comment to solve this. Hope the change is fine for you Anja. -
Oliver Klee voted on patch set 3 V +1 CR +1 10/09/22, 16:29
-
Stefan Bürk voted on patch set 3 V +2 CR +2 10/09/22, 17:38
-
Stefan Bürk merged patch set 4 10/09/22, 17:38