Review main Merged

76033[TASK] Replace prophecy in PreviewModuleTest

Anja Leichsenring CR +2 V +2 Normal +41 −37 updated 10/10/22, 14:48

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Anja Leichsenring uploaded patch set 1 10/09/22, 11:57

  2. core-ci voted on patch set 1 V +1 10/09/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32119

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/09/22, 13:03

  4. Stefan Bürk uploaded patch set 2 10/09/22, 13:50

  5. core-ci voted on patch set 2 V +1 10/09/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32124

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/09/22, 13:59

  7. Stefan Bürk commented on patch set 2 10/09/22, 13:59

    Removed the superflous prophecy trait, which was a leftover.
  8. Oliver Klee voted on patch set 2 V +1 CR +1 10/09/22, 16:29

  9. Christian Kuhn voted on patch set 2 CR -1 10/10/22, 12:22

  10. Christian Kuhn uploaded patch set 3 10/10/22, 12:30

  11. core-ci voted on patch set 3 V +1 10/10/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32138

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 10/10/22, 12:39

  13. Stefan Bürk voted on patch set 3 V +1 CR +1 10/10/22, 12:59

  14. Andreas Kienast voted on patch set 3 V +1 CR +1 10/10/22, 13:03

  15. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/10/22, 14:48

  16. Anja Leichsenring merged patch set 4 10/10/22, 14:48