Review main Merged

76036[BUGFIX] Ensure working PostgreSQL libpq version environment check

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 10/10/22, 13:10

Commit message

Prior to PHP8.0 the long libpq version (`PGSQL_LIBPQ_VERSION_STR`)
contained compiler informations, which is used in the install tool
environment checks. Since PHP8.0 the value is identical to the short
version (`PGSQL_LIBPQ_VERSION`) and using the long form is deprecated.

See: https://www.php.net/manual/en/pgsql.constants.php

This change now simply use the short version for the PostgreSQL libpq
check, avoiding nasty PHP version flip-flop checkings.

The minimum version has been adjusted along the way.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/09/22, 22:12

  2. core-ci voted on patch set 1 V +1 10/09/22, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32127

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/10/22, 12:20

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 10/10/22, 12:58

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 10/10/22, 13:10

  6. Stefan Bürk merged patch set 2 10/10/22, 13:10