Review main Merged

76038[BUGFIX] Ensure `DB Check`->`Full Search` module works with PostgresSQL

Stefan Bürk CR +2 V +2 Easy +38 −5 updated 10/10/22, 15:53

Commit message

PostgresSQL is really picky about types and used operators. Thus using
for example a `like` comparision on non string/text based fields fails
hard. Database errors like following indicates this issue:

>  Undefined function: 7 ERROR: operator does not exist:
>  smallint ~~ unknown

This changes implicit converts field data to a text representation
for PostgresSQL, if field is not compatible. In case of small/tinyint
fields a double cast is used, means casting to integer and then to
string before applying the like comparison on it.

The choosen solution is used to have a comparible behaviour against the
other supported dbms systems like MariaDB, MySQL and SQLite, also doing
a full search on all fields may be a bad decision. The whole search and
full-search across all types should be reconsidered generally.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 10/10/22, 00:28

  2. Stefan Bürk updated the commit message in patch set 2 10/10/22, 00:29

  3. core-ci voted on patch set 1 V +1 10/10/22, 00:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32129

  4. core-ci voted on patch set 2 V +1 10/10/22, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32130

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/10/22, 12:19

  6. Andreas Kienast uploaded patch set 3 10/10/22, 12:56

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 10/10/22, 12:56

  8. core-ci voted on patch set 3 V +1 10/10/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32141

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 10/10/22, 14:32

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 10/10/22, 15:53

  11. Stefan Bürk merged patch set 4 10/10/22, 15:53