Review 11.5 Merged

76052[BUGFIX] Ensure ext:redirects backend module pagination works

Christian Kuhn CR +2 V +2 Easy +7 −1 updated 10/10/22, 12:17

Commit message

PostgresSQL is picky if aggregation functions like `order by`,
`group by` and similar are used, but missing the corresponding
columns in the "SELECT" column listing.

ext:redirects backend module builds query using the QueryBuilder
based on the demand dto object, which so far is a good practice.
To get the total count of records based on selection and properly
building the pagination it uses the same technique but executing
a simple count query, which leads to the aggregation error using
PostgresSQL dbms due the containing `order by` sortings.

This changes simply omits the orderBy part of the build query to
avoid this error and still counting on a correct full dataset.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 10/10/22, 10:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/10/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32137

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/10/22, 12:17

  4. Christian Kuhn merged patch set 2 10/10/22, 12:17